Add support for SMB storage in connectedEnvironment #29158

anandgmenon · 2024-05-20T05:27:16Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-05-20T05:27:20Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-05-20T05:27:20Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 11 Errors, 14 Warnings failed [Detail]

Compared specs (v0.10.8)	new version	base version
CommonDefinitions.json	2024-02-02-preview(2d2acd6)	2023-05-01(main)
CommonDefinitions.json	2024-02-02-preview(2d2acd6)	2023-11-02-preview(main)
ConnectedEnvironmentsStorages.json	2024-02-02-preview(2d2acd6)	2023-05-01(main)
ConnectedEnvironmentsStorages.json	2024-02-02-preview(2d2acd6)	2023-11-02-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
`❌` 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
`❌` 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
`❌` 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
`❌` 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
`❌` 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
`❌` 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
`❌` 1023 - TypeFormatChanged	The new version has a different format 'uuid' than the previous one ''. New: common-types/resource-management/v5/types.json#L204:9 Old: common-types/resource-management/v3/types.json#L204:9
`❌` 1023 - TypeFormatChanged	The new version has a different format 'uuid' than the previous one ''. New: common-types/resource-management/v5/types.json#L210:9 Old: common-types/resource-management/v3/types.json#L209:9
`❌` 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
`❌` 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format 'uuid' than the previous one ''. New: common-types/resource-management/v5/types.json#L204:9 Old: common-types/resource-management/v3/types.json#L204:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format 'uuid' than the previous one ''. New: common-types/resource-management/v5/types.json#L210:9 Old: common-types/resource-management/v3/types.json#L209:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format 'arm-id' than the previous one ''. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9

️⚠️LintDiff: 0 Warnings warning [Detail]

Compared specs (v2.2.2)	new version	base version
package-preview-2024-02	package-preview-2024-02(2d2acd6)	package-preview-2024-02(release-app-Microsoft.App-2024-02-02-preview)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L310
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L473
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L522
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L596
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L596
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L596
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L617
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L621
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L625
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L705
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L705
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L705
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L722
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L1147
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L1194
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L1678
`❌` ResourceNameRestriction	The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2024-02-02-preview/ConnectedEnvironmentsStorages.json#L18
`❌` XmsPageableForListCalls	`x-ms-pageable` extension must be specified for LIST APIs. Location: Microsoft.App/preview/2024-02-02-preview/ConnectedEnvironmentsStorages.json#L19
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.App/preview/2024-02-02-preview/ConnectedEnvironmentsStorages.json#L47
`❌` ResourceNameRestriction	The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2024-02-02-preview/ConnectedEnvironmentsStorages.json#L65
`❌` ResourceNameRestriction	The resource name parameter 'storageName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2024-02-02-preview/ConnectedEnvironmentsStorages.json#L65
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.App/preview/2024-02-02-preview/ConnectedEnvironmentsStorages.json#L118
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L168
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L242
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L387
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L848
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L1214
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L1394
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L1470
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L1540

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-05-20T05:27:21Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning in generating from 247c246. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-appcontainers [Preview SDK Changes]
- azure_mgmt_appcontainers-1.0.0b1-py3-none-any.whl
- azure-mgmt-appcontainers-1.0.0b1.zip

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded in generating from 247c246. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-appcontainers [Preview SDK Changes]
- pom.xml
- azure-resourcemanager-appcontainers-1.0.0-beta.8-sources.jar
- azure-resourcemanager-appcontainers-1.0.0-beta.8.jar

️❌ azure-sdk-for-go failed [Detail]

❌Code Generator Failed in generating from 247c246. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
cmderr	[generator automation-v2] [ERROR] total 1 error(s):
cmderr	[generator automation-v2] [ERROR] failed to execute `go generate` 'WARNING: Unable to find version for /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/appcontainers/armappcontainers
cmderr	[generator automation-v2] [ERROR] Cannot find go module under resourcemanager/appcontainers/armappcontainers, try to build in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/appcontainers/armappcontainers
cmderr	[generator automation-v2] [ERROR] ##[command]Cleaning auto-generated files in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/appcontainers/armappcontainers
cmderr	[generator automation-v2] [ERROR] ##[command]Executing autorest.go in  /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/appcontainers/armappcontainers
cmderr	[generator automation-v2] [ERROR] autorest --use=@autorest/go@4.0.0-preview.63 --go --track2 --output-folder=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/appcontainers/armappcontainers --clear-output-folder=false --go.clear-output-folder=false --honor-body-placement=true --remove-unreferenced-types=false ./autorest.md
cmderr	[generator automation-v2] [ERROR] AutoRest code generation utility [cli version: 3.6.1; node: v18.20.2]
cmderr	[generator automation-v2] [ERROR] (C) 2018 Microsoft Corporation.
cmderr	[generator automation-v2] [ERROR] https://aka.ms/autorest
cmderr	[generator automation-v2] [ERROR] There is a new version of AutoRest available (3.7.1).
cmderr	[generator automation-v2] [ERROR] > You can install the newer version with with npm install -g autorest@latest
cmderr	[generator automation-v2] [ERROR] info    |    Loading AutoRest core      '/home/cloudtest/.autorest/@autorestcore@3.10.2/nodemodules/@autorest/core/dist' (3.10.2)
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.1.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.1.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.2.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.1.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.1.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.1.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.2.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.3.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.4.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.5.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.6.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.7.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.8.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.9.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.10.suppress which is deprecated and will be removed in the future.
cmderr	[generator automation-v2] [ERROR] info    |    Installing AutoRest extension '@autorest/go' (4.0.0-preview.63 -> 4.0.0-preview.63)
cmderr	[generator automation-v2] [ERROR] info    |    Installed AutoRest extension '@autorest/go' (4.0.0-preview.63->4.0.0-preview.63)
cmderr	[generator automation-v2] [ERROR] info    |    Installing AutoRest extension '@autorest/modelerfour' (4.26.2 -> 4.26.2)
cmderr	[generator automation-v2] [ERROR] info    |    Installed AutoRest extension '@autorest/modelerfour' (4.26.2->4.26.2)
cmderr	[generator automation-v2] [ERROR] warning | IgnoredPropertyNextToRef | Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > DaprComponentServiceBinding > properties > metadata)
cmderr	[generator automation-v2] [ERROR] keys: [ 'type' ]
cmderr	[generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json:933:9
cmderr	[generator automation-v2] [ERROR] warning | IgnoredPropertyNextToRef | Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > JavaComponent > properties > properties)
cmderr	[generator automation-v2] [ERROR] keys: [ 'type' ]
cmderr	[generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2024-02-02-preview/JavaComponents.json:401:9
cmderr	[generator automation-v2] [ERROR] warning | IgnoredPropertyNextToRef | Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > Resource > properties > systemData)
cmderr	[generator automation-v2] [ERROR] keys: [ 'type' ]
cmderr	[generator automation-v2] [ERROR] warning | PreCheck/CheckDuplicateSchemas | Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmderr	[generator automation-v2] [ERROR] error   | PreCheck/DuplicateSchema | Duplicate Schema named 'Secret' (2 differences):
cmderr	[generator automation-v2] [ERROR] - properties.identity: {"$ref":"#/components/schemas/schemas:294","description":"Resource ID of a managed identity to authenticate with Azure Key Vault, or System to use a system-assigned identity."} => <none>
cmderr	[generator automation-v2] [ERROR] - properties.keyVaultUrl: {"$ref":"#/components/schemas/schemas:295","description":"Azure Key Vault URL pointing to the secret referenced by the container app."} => <none>; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
cmderr	[generator automation-v2] [ERROR] error   | PreCheck/DuplicateSchema | Duplicate Schema named 'Resource' (3 differences):
cmderr	[generator automation-v2] [ERROR] - properties.id.$ref: "#/components/schemas/schemas:1253" => "#/components/schemas/schemas:1363"
cmderr	[generator automation-v2] [ERROR] - properties.id.description: "Fully qualified resource ID for the resource. E.g. \"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{resourceType}/{resourceName}\"" => "Fully qualified resource ID for the resource. Ex - /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{resourceType}/{resourceName}"
cmderr	[generator automation-v2] [ERROR] - properties.systemData.type: <none> => "object"; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
cmderr	[generator automation-v2] [ERROR] error   | PreCheck/DuplicateSchema | Duplicate Schema named 'ProxyResource' (1 differences):
cmderr	[generator automation-v2] [ERROR] - allOf.0.$ref: "#/components/schemas/schemas:1252" => "#/components/schemas/schemas:1362"; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
cmderr	[generator automation-v2] [ERROR] fatal   | Error: 3 errors occured -- cannot continue.
cmderr	[generator automation-v2] [ERROR] fatal   | Process() cancelled due to failure
cmderr	[generator automation-v2] [ERROR] error   |   Error: Plugin prechecker reported failure.
cmderr	[generator automation-v2] [ERROR] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
cmderr	[generator automation-v2] [ERROR] ##[error]Error running autorest.go
cmderr	[generator automation-v2] [ERROR] build.go:5: running "pwsh": exit status 1
cmderr	[generator automation-v2] [ERROR] ': exit status 1
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2
warn	Skip package processing as generation is failed

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded in generating from 247c246. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-appcontainers [Preview SDK Changes]
- azure-arm-appcontainers-3.0.0-beta.1.tgz

️❌ azure-resource-manager-schemas failed [Detail]

❌Code Generator Failed in generating from 247c246. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
cmderr	[initScript.sh]  notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.5.0 -> 10.8.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.8.0>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.8.0` to update!
cmderr	[initScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Skip package processing as generation is failed
error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded in generating from 247c246. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.app.DefaultTag [Preview SDK Changes]
- Az.ContainerAppsApi.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-05-20T05:27:21Z

Generated ApiView

Language	Package Name	ApiView Link
Java	azure-resourcemanager-appcontainers	https://apiview.dev/Assemblies/Review/7da9ac1e2db64477ada2ba8bbb71169b?revisionId=35ecb290a5a9444bab2999f046b541d0
JavaScript	@azure/arm-appcontainers	https://apiview.dev/Assemblies/Review/ba41cd9978b542efb0688a072b2319a1?revisionId=8ba9dde501dd4a2d8a3cc9ab440b666f
Swagger	Microsoft.App	https://apiview.dev/Assemblies/Review/53999dbad23b45cba7812a00a713cab8?revisionId=cc1b9ee49d5349aba4c8b80d36b4926c

...resource-manager/Microsoft.App/preview/2024-02-02-preview/ConnectedEnvironmentsStorages.json

anandgmenon · 2024-05-27T05:13:44Z

/pr RequestMerge

Add support for SMB storage in connectedEnvironment

2e59f1c

anandgmenon marked this pull request as ready for review May 20, 2024 05:28

anandgmenon requested a review from Juliehzl as a code owner May 20, 2024 05:28

azure-sdk mentioned this pull request May 20, 2024

[AutoPR azure-resourcemanager-appcontainers] Add support for SMB storage in connectedEnvironment azure-sdk/azure-sdk-for-java#10586

Closed

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 20, 2024

ms-henglu added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 21, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 21, 2024

LaylaLiu-gmail reviewed May 21, 2024

View reviewed changes

...resource-manager/Microsoft.App/preview/2024-02-02-preview/ConnectedEnvironmentsStorages.json Outdated Show resolved Hide resolved

move smb properties to common

3395cce

azure-sdk mentioned this pull request May 22, 2024

[AutoPR Az.app.DefaultTag] Add support for SMB storage in connectedEnvironment azure-sdk/azure-powershell#6715

Closed

fix reference

2d2acd6

microsoft-github-policy-service bot added the MergeRequested Part of the ARM PR review workflow label May 27, 2024

razvanbadea-msft approved these changes May 27, 2024

View reviewed changes

razvanbadea-msft merged commit f3106cc into Azure:release-app-Microsoft.App-2024-02-02-preview May 27, 2024
23 of 27 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for SMB storage in connectedEnvironment #29158

Add support for SMB storage in connectedEnvironment #29158

anandgmenon commented May 20, 2024 •

edited by openapi-workflow-bot bot

openapi-pipeline-app bot commented May 20, 2024 •

edited

openapi-pipeline-app bot commented May 20, 2024 •

edited

openapi-pipeline-app bot commented May 20, 2024 •

edited

openapi-pipeline-app bot commented May 20, 2024 •

edited

anandgmenon commented May 27, 2024

Add support for SMB storage in connectedEnvironment #29158

Add support for SMB storage in connectedEnvironment #29158

Conversation

anandgmenon commented May 20, 2024 • edited by openapi-workflow-bot bot

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented May 20, 2024 • edited

Next Steps to Merge

openapi-pipeline-app bot commented May 20, 2024 • edited

Swagger Validation Report

openapi-pipeline-app bot commented May 20, 2024 • edited

Swagger Generation Artifacts

openapi-pipeline-app bot commented May 20, 2024 • edited

Generated ApiView

anandgmenon commented May 27, 2024

anandgmenon commented May 20, 2024 •

edited by openapi-workflow-bot bot

openapi-pipeline-app bot commented May 20, 2024 •

edited

openapi-pipeline-app bot commented May 20, 2024 •

edited

openapi-pipeline-app bot commented May 20, 2024 •

edited

openapi-pipeline-app bot commented May 20, 2024 •

edited