Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS 1_3 support for storage #29175

Merged
merged 4 commits into from
May 30, 2024
Merged

Add TLS 1_3 support for storage #29175

merged 4 commits into from
May 30, 2024

Conversation

usharma6
Copy link
Contributor

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented May 21, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented May 21, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail]
Compared specs (v0.10.9) new version base version
storage.json 2023-05-01(3e9f560) 2023-05-01(main)
Rule Message
1020 - AddedEnumValue The new version is adding enum value(s) 'Cold' from the old version.
New: Microsoft.Storage/stable/2023-05-01/storage.json#L3186:9
Old: Microsoft.Storage/stable/2023-05-01/storage.json#L3186:9
1020 - AddedEnumValue The new version is adding enum value(s) 'TLS1_3' from the old version.
New: Microsoft.Storage/stable/2023-05-01/storage.json#L3251:9
Old: Microsoft.Storage/stable/2023-05-01/storage.json#L3250:9
1020 - AddedEnumValue The new version is adding enum value(s) 'Cold' from the old version.
New: Microsoft.Storage/stable/2023-05-01/storage.json#L3853:9
Old: Microsoft.Storage/stable/2023-05-01/storage.json#L3851:9
1020 - AddedEnumValue The new version is adding enum value(s) 'TLS1_3' from the old version.
New: Microsoft.Storage/stable/2023-05-01/storage.json#L3951:9
Old: Microsoft.Storage/stable/2023-05-01/storage.json#L3948:9
1020 - AddedEnumValue The new version is adding enum value(s) 'Cold' from the old version.
New: Microsoft.Storage/stable/2023-05-01/storage.json#L4207:9
Old: Microsoft.Storage/stable/2023-05-01/storage.json#L4203:9
1020 - AddedEnumValue The new version is adding enum value(s) 'TLS1_3' from the old version.
New: Microsoft.Storage/stable/2023-05-01/storage.json#L4272:9
Old: Microsoft.Storage/stable/2023-05-01/storage.json#L4267:9
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2023-05 package-2023-05(3e9f560) package-2023-05(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
GetCollectionResponseSchema The response in the GET collection operation 'Queue_List' does not match the response definition in the individual GET operation 'Queue_Get' .
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L18
GetCollectionResponseSchema The response in the GET collection operation 'BlobContainers_List' does not match the response definition in the individual GET operation 'BlobContainers_Get' .
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L18
GetCollectionResponseSchema The response in the GET collection operation 'FileShares_List' does not match the response definition in the individual GET operation 'FileShares_Get' .
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L18
RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L36
OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Storage/operations' does not match the ARM specification. Please standardize the schema.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L39
OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L40
RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L69
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L72
PostResponseCodes Synchronous POST operations must have one of the following combinations of responses - 200 and default ; 204 and default. They also must not have other response codes.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L83
RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L111
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L122
PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'StorageAccounts_Create' Request Model: 'parameters[2].schema' Response Model: 'responses[200].schema'
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L122
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L122
RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L189
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L196
DeleteResponseCodes Synchronous delete operations must have responses with 200, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L202
RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L227
ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L262
RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L291
PatchResponseCodes Synchronous PATCH operations must have responses with 200 and default return codes. They also must not have other response codes.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L300
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:type.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:name.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:keySource.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:sasExpirationPeriod.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:expirationAction.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:expirationAction.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:keyExpirationPeriodInDays.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:directoryServiceOptions.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:domainName.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:domainGuid.
Location: Microsoft.Storage/stable/2023-05-01/storage.json#L343
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented May 21, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed in generating from 8c98e83. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact
  • Azure.ResourceManager.Storage [Preview SDK Changes]
    info	[Changelog]
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from 8c98e83. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-storage [Preview SDK Changes]
    • azure-mgmt-storage-21.1.0.zip
    • azure_mgmt_storage-21.1.0-py3-none-any.whl
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurationsOperations
    info	[Changelog]   - Added operation group StorageTaskAssignmentInstancesReportOperations
    info	[Changelog]   - Added operation group StorageTaskAssignmentsInstancesReportOperations
    info	[Changelog]   - Added operation group StorageTaskAssignmentsOperations
    info	[Changelog]   - Model LocalUser has a new parameter allow_acl_authorization
    info	[Changelog]   - Model LocalUser has a new parameter extended_groups
    info	[Changelog]   - Model LocalUser has a new parameter group_id
    info	[Changelog]   - Model LocalUser has a new parameter is_nf_sv3_enabled
    info	[Changelog]   - Model LocalUser has a new parameter user_id
    info	[Changelog]   - Model LocalUsers has a new parameter next_link
    info	[Changelog]   - Model StorageAccount has a new parameter enable_extended_groups
    info	[Changelog]   - Model StorageAccountCreateParameters has a new parameter enable_extended_groups
    info	[Changelog]   - Model StorageAccountUpdateParameters has a new parameter enable_extended_groups
    info	[Changelog]   - Operation LocalUsersOperations.list has a new optional parameter filter
    info	[Changelog]   - Operation LocalUsersOperations.list has a new optional parameter include
    info	[Changelog]   - Operation LocalUsersOperations.list has a new optional parameter maxpagesize
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 8c98e83. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-storage-generated [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-storage-generated-1.0.0-beta.1-sources.jar
    • azure-resourcemanager-storage-generated-1.0.0-beta.1.jar
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 8c98e83. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/storage/armstorage [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `AccessTierCold` added to enum type `AccessTier`
    info	[Changelog] - New value `ExpirationActionBlock` added to enum type `ExpirationAction`
    info	[Changelog] - New value `MinimumTLSVersionTLS13` added to enum type `MinimumTLSVersion`
    info	[Changelog] - New value `ProvisioningStateCanceled`, `ProvisioningStateDeleting`, `ProvisioningStateFailed`, `ProvisioningStateValidateSubscriptionQuotaBegin`, `ProvisioningStateValidateSubscriptionQuotaEnd` added to enum type `ProvisioningState`
    info	[Changelog] - New value `PublicNetworkAccessSecuredByPerimeter` added to enum type `PublicNetworkAccess`
    info	[Changelog] - New enum type `IssueType` with values `IssueTypeConfigurationPropagationFailure`, `IssueTypeUnknown`
    info	[Changelog] - New enum type `ListLocalUserIncludeParam` with values `ListLocalUserIncludeParamNfsv3`
    info	[Changelog] - New enum type `NetworkSecurityPerimeterConfigurationProvisioningState` with values `NetworkSecurityPerimeterConfigurationProvisioningStateAccepted`, `NetworkSecurityPerimeterConfigurationProvisioningStateCanceled`, `NetworkSecurityPerimeterConfigurationProvisioningStateDeleting`, `NetworkSecurityPerimeterConfigurationProvisioningStateFailed`, `NetworkSecurityPerimeterConfigurationProvisioningStateSucceeded`
    info	[Changelog] - New enum type `NspAccessRuleDirection` with values `NspAccessRuleDirectionInbound`, `NspAccessRuleDirectionOutbound`
    info	[Changelog] - New enum type `ResourceAssociationAccessMode` with values `ResourceAssociationAccessModeAudit`, `ResourceAssociationAccessModeEnforced`, `ResourceAssociationAccessModeLearning`
    info	[Changelog] - New enum type `RunResult` with values `RunResultFailed`, `RunResultSucceeded`
    info	[Changelog] - New enum type `RunStatusEnum` with values `RunStatusEnumFinished`, `RunStatusEnumInProgress`
    info	[Changelog] - New enum type `Severity` with values `SeverityError`, `SeverityWarning`
    info	[Changelog] - New enum type `TriggerType` with values `TriggerTypeOnSchedule`, `TriggerTypeRunOnce`
    info	[Changelog] - New function `*ClientFactory.NewNetworkSecurityPerimeterConfigurationsClient() *NetworkSecurityPerimeterConfigurationsClient`
    info	[Changelog] - New function `*ClientFactory.NewTaskAssignmentInstancesReportClient() *TaskAssignmentInstancesReportClient`
    info	[Changelog] - New function `*ClientFactory.NewTaskAssignmentsClient() *TaskAssignmentsClient`
    info	[Changelog] - New function `*ClientFactory.NewTaskAssignmentsInstancesReportClient() *TaskAssignmentsInstancesReportClient`
    info	[Changelog] - New function `NewTaskAssignmentInstancesReportClient(string, azcore.TokenCredential, *arm.ClientOptions) (*TaskAssignmentInstancesReportClient, error)`
    info	[Changelog] - New function `*TaskAssignmentInstancesReportClient.NewListPager(string, string, string, *TaskAssignmentInstancesReportClientListOptions) *runtime.Pager[TaskAssignmentInstancesReportClientListResponse]`
    info	[Changelog] - New function `NewTaskAssignmentsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*TaskAssignmentsClient, error)`
    info	[Changelog] - New function `*TaskAssignmentsClient.BeginCreate(context.Context, string, string, string, TaskAssignment, *TaskAssignmentsClientBeginCreateOptions) (*runtime.Poller[TaskAssignmentsClientCreateResponse], error)`
    info	[Changelog] - New function `*TaskAssignmentsClient.BeginDelete(context.Context, string, string, string, *TaskAssignmentsClientBeginDeleteOptions) (*runtime.Poller[TaskAssignmentsClientDeleteResponse], error)`
    info	[Changelog] - New function `*TaskAssignmentsClient.Get(context.Context, string, string, string, *TaskAssignmentsClientGetOptions) (TaskAssignmentsClientGetResponse, error)`
    info	[Changelog] - New function `*TaskAssignmentsClient.NewListPager(string, string, *TaskAssignmentsClientListOptions) *runtime.Pager[TaskAssignmentsClientListResponse]`
    info	[Changelog] - New function `*TaskAssignmentsClient.BeginUpdate(context.Context, string, string, string, TaskAssignmentUpdateParameters, *TaskAssignmentsClientBeginUpdateOptions) (*runtime.Poller[TaskAssignmentsClientUpdateResponse], error)`
    info	[Changelog] - New function `NewTaskAssignmentsInstancesReportClient(string, azcore.TokenCredential, *arm.ClientOptions) (*TaskAssignmentsInstancesReportClient, error)`
    info	[Changelog] - New function `*TaskAssignmentsInstancesReportClient.NewListPager(string, string, *TaskAssignmentsInstancesReportClientListOptions) *runtime.Pager[TaskAssignmentsInstancesReportClientListResponse]`
    info	[Changelog] - New function `NewNetworkSecurityPerimeterConfigurationsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*NetworkSecurityPerimeterConfigurationsClient, error)`
    info	[Changelog] - New function `*NetworkSecurityPerimeterConfigurationsClient.Get(context.Context, string, string, string, *NetworkSecurityPerimeterConfigurationsClientGetOptions) (NetworkSecurityPerimeterConfigurationsClientGetResponse, error)`
    info	[Changelog] - New function `*NetworkSecurityPerimeterConfigurationsClient.NewListPager(string, string, *NetworkSecurityPerimeterConfigurationsClientListOptions) *runtime.Pager[NetworkSecurityPerimeterConfigurationsClientListResponse]`
    info	[Changelog] - New function `*NetworkSecurityPerimeterConfigurationsClient.BeginReconcile(context.Context, string, string, string, *NetworkSecurityPerimeterConfigurationsClientBeginReconcileOptions) (*runtime.Poller[NetworkSecurityPerimeterConfigurationsClientReconcileResponse], error)`
    info	[Changelog] - New struct `ExecutionTarget`
    info	[Changelog] - New struct `ExecutionTargetUpdate`
    info	[Changelog] - New struct `ExecutionTrigger`
    info	[Changelog] - New struct `ExecutionTriggerUpdate`
    info	[Changelog] - New struct `NetworkSecurityPerimeter`
    info	[Changelog] - New struct `NetworkSecurityPerimeterConfiguration`
    info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationList`
    info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationProperties`
    info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationPropertiesProfile`
    info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationPropertiesResourceAssociation`
    info	[Changelog] - New struct `NspAccessRule`
    info	[Changelog] - New struct `NspAccessRuleProperties`
    info	[Changelog] - New struct `NspAccessRulePropertiesSubscriptionsItem`
    info	[Changelog] - New struct `ProvisioningIssue`
    info	[Changelog] - New struct `ProvisioningIssueProperties`
    info	[Changelog] - New struct `ProxyResourceAutoGenerated`
    info	[Changelog] - New struct `ResourceAutoGenerated`
    info	[Changelog] - New struct `TaskAssignment`
    info	[Changelog] - New struct `TaskAssignmentExecutionContext`
    info	[Changelog] - New struct `TaskAssignmentProperties`
    info	[Changelog] - New struct `TaskAssignmentReport`
    info	[Changelog] - New struct `TaskAssignmentUpdateExecutionContext`
    info	[Changelog] - New struct `TaskAssignmentUpdateParameters`
    info	[Changelog] - New struct `TaskAssignmentUpdateProperties`
    info	[Changelog] - New struct `TaskAssignmentUpdateReport`
    info	[Changelog] - New struct `TaskAssignmentsList`
    info	[Changelog] - New struct `TaskReportInstance`
    info	[Changelog] - New struct `TaskReportProperties`
    info	[Changelog] - New struct `TaskReportSummary`
    info	[Changelog] - New struct `TriggerParameters`
    info	[Changelog] - New struct `TriggerParametersUpdate`
    info	[Changelog] - New field `EnableExtendedGroups` in struct `AccountProperties`
    info	[Changelog] - New field `EnableExtendedGroups` in struct `AccountPropertiesCreateParameters`
    info	[Changelog] - New field `EnableExtendedGroups` in struct `AccountPropertiesUpdateParameters`
    info	[Changelog] - New field `AllowACLAuthorization`, `ExtendedGroups`, `GroupID`, `IsNFSv3Enabled`, `UserID` in struct `LocalUserProperties`
    info	[Changelog] - New field `NextLink` in struct `LocalUsers`
    info	[Changelog] - New field `Filter`, `Include`, `Maxpagesize` in struct `LocalUsersClientListOptions`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 125 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 8c98e83. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-storage [Preview SDK Changes]
    • azure-arm-storage-18.3.0.tgz
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurations
    info	[Changelog]   - Added operation group StorageTaskAssignmentInstancesReport
    info	[Changelog]   - Added operation group StorageTaskAssignments
    info	[Changelog]   - Added operation group StorageTaskAssignmentsInstancesReport
    info	[Changelog]   - Added Interface ExecutionTarget
    info	[Changelog]   - Added Interface ExecutionTargetUpdate
    info	[Changelog]   - Added Interface ExecutionTrigger
    info	[Changelog]   - Added Interface ExecutionTriggerUpdate
    info	[Changelog]   - Added Interface NetworkSecurityPerimeter
    info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfiguration
    info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationList
    info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationPropertiesProfile
    info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationPropertiesResourceAssociation
    info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsGetOptionalParams
    info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsListOptionalParams
    info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsReconcileHeaders
    info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsReconcileOptionalParams
    info	[Changelog]   - Added Interface NspAccessRule
    info	[Changelog]   - Added Interface NspAccessRuleProperties
    info	[Changelog]   - Added Interface NspAccessRulePropertiesSubscriptionsItem
    info	[Changelog]   - Added Interface ProvisioningIssue
    info	[Changelog]   - Added Interface ProvisioningIssueProperties
    info	[Changelog]   - Added Interface ProxyResourceAutoGenerated
    info	[Changelog]   - Added Interface ResourceAutoGenerated
    info	[Changelog]   - Added Interface StorageTaskAssignment
    info	[Changelog]   - Added Interface StorageTaskAssignmentExecutionContext
    info	[Changelog]   - Added Interface StorageTaskAssignmentInstancesReportListNextOptionalParams
    info	[Changelog]   - Added Interface StorageTaskAssignmentInstancesReportListOptionalParams
    info	[Changelog]   - Added Interface StorageTaskAssignmentProperties
    info	[Changelog]   - Added Interface StorageTaskAssignmentReport
    info	[Changelog]   - Added Interface StorageTaskAssignmentsCreateHeaders
    info	[Changelog]   - Added Interface StorageTaskAssignmentsCreateOptionalParams
    info	[Changelog]   - Added Interface StorageTaskAssignmentsDeleteHeaders
    info	[Changelog]   - Added Interface StorageTaskAssignmentsDeleteOptionalParams
    info	[Changelog]   - Added Interface StorageTaskAssignmentsGetOptionalParams
    info	[Changelog]   - Added Interface StorageTaskAssignmentsInstancesReportListNextOptionalParams
    info	[Changelog]   - Added Interface StorageTaskAssignmentsInstancesReportListOptionalParams
    info	[Changelog]   - Added Interface StorageTaskAssignmentsList
    info	[Changelog]   - Added Interface StorageTaskAssignmentsListNextOptionalParams
    info	[Changelog]   - Added Interface StorageTaskAssignmentsListOptionalParams
    info	[Changelog]   - Added Interface StorageTaskAssignmentsUpdateHeaders
    info	[Changelog]   - Added Interface StorageTaskAssignmentsUpdateOptionalParams
    info	[Changelog]   - Added Interface StorageTaskAssignmentUpdateExecutionContext
    info	[Changelog]   - Added Interface StorageTaskAssignmentUpdateParameters
    info	[Changelog]   - Added Interface StorageTaskAssignmentUpdateProperties
    info	[Changelog]   - Added Interface StorageTaskAssignmentUpdateReport
    info	[Changelog]   - Added Interface StorageTaskReportInstance
    info	[Changelog]   - Added Interface StorageTaskReportProperties
    info	[Changelog]   - Added Interface StorageTaskReportSummary
    info	[Changelog]   - Added Interface TriggerParameters
    info	[Changelog]   - Added Interface TriggerParametersUpdate
    info	[Changelog]   - Added Type Alias IssueType
    info	[Changelog]   - Added Type Alias ListLocalUserIncludeParam
    info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationProvisioningState
    info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationsGetResponse
    info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationsListResponse
    info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationsReconcileResponse
    info	[Changelog]   - Added Type Alias NspAccessRuleDirection
    info	[Changelog]   - Added Type Alias ResourceAssociationAccessMode
    info	[Changelog]   - Added Type Alias RunResult
    info	[Changelog]   - Added Type Alias RunStatusEnum
    info	[Changelog]   - Added Type Alias Severity
    info	[Changelog]   - Added Type Alias StorageTaskAssignmentInstancesReportListNextResponse
    info	[Changelog]   - Added Type Alias StorageTaskAssignmentInstancesReportListResponse
    info	[Changelog]   - Added Type Alias StorageTaskAssignmentsCreateResponse
    info	[Changelog]   - Added Type Alias StorageTaskAssignmentsDeleteResponse
    info	[Changelog]   - Added Type Alias StorageTaskAssignmentsGetResponse
    info	[Changelog]   - Added Type Alias StorageTaskAssignmentsInstancesReportListNextResponse
    info	[Changelog]   - Added Type Alias StorageTaskAssignmentsInstancesReportListResponse
    info	[Changelog]   - Added Type Alias StorageTaskAssignmentsListNextResponse
    info	[Changelog]   - Added Type Alias StorageTaskAssignmentsListResponse
    info	[Changelog]   - Added Type Alias StorageTaskAssignmentsUpdateResponse
    info	[Changelog]   - Added Type Alias TriggerType
    info	[Changelog]   - Interface LocalUser has a new optional parameter allowAclAuthorization
    info	[Changelog]   - Interface LocalUser has a new optional parameter extendedGroups
    info	[Changelog]   - Interface LocalUser has a new optional parameter groupId
    info	[Changelog]   - Interface LocalUser has a new optional parameter isNFSv3Enabled
    info	[Changelog]   - Interface LocalUser has a new optional parameter userId
    info	[Changelog]   - Interface LocalUsers has a new optional parameter nextLink
    info	[Changelog]   - Interface LocalUsersListOptionalParams has a new optional parameter filter
    info	[Changelog]   - Interface LocalUsersListOptionalParams has a new optional parameter include
    info	[Changelog]   - Interface LocalUsersListOptionalParams has a new optional parameter maxpagesize
    info	[Changelog]   - Interface StorageAccount has a new optional parameter enableExtendedGroups
    info	[Changelog]   - Interface StorageAccountCreateParameters has a new optional parameter enableExtendedGroups
    info	[Changelog]   - Interface StorageAccountUpdateParameters has a new optional parameter enableExtendedGroups
    info	[Changelog]   - Added Enum KnownIssueType
    info	[Changelog]   - Added Enum KnownListLocalUserIncludeParam
    info	[Changelog]   - Added Enum KnownNetworkSecurityPerimeterConfigurationProvisioningState
    info	[Changelog]   - Added Enum KnownNspAccessRuleDirection
    info	[Changelog]   - Added Enum KnownResourceAssociationAccessMode
    info	[Changelog]   - Added Enum KnownRunResult
    info	[Changelog]   - Added Enum KnownRunStatusEnum
    info	[Changelog]   - Added Enum KnownSeverity
    info	[Changelog]   - Enum KnownExpirationAction has a new value Block
    info	[Changelog]   - Enum KnownMinimumTlsVersion has a new value TLS13
    info	[Changelog]   - Enum KnownPublicNetworkAccess has a new value SecuredByPerimeter
️❌ azure-resource-manager-schemas failed [Detail]
  • Code Generator Failed in generating from 8c98e83. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[initScript.sh] npm notice To update run: npm install -g npm@10.8.1
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Skip package processing as generation is failed
    error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
️️✔️ azure-powershell succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 8c98e83. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ️✔️Az.storage.DefaultTag [Preview SDK Changes]
    • Az.Storage.0.1.0.nupkg
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented May 21, 2024

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/storage/armstorage Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java azure-resourcemanager-storage-generated Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript @azure/arm-storage Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Swagger Microsoft.Storage Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

@TimLovellSmith
Copy link
Member

Tagging for version review as I think new enum values are supposed to be in a new version .

@usharma6
Copy link
Contributor Author

Tagging for version review as I think new enum values are supposed to be in a new version .

This version is not yet released, hence adding the new enum values to this version

@AzureRestAPISpecReview AzureRestAPISpecReview removed the VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required label May 24, 2024
@razvanbadea-msft razvanbadea-msft added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 26, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 26, 2024
@usharma6
Copy link
Contributor Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 29175 in repo Azure/azure-rest-api-specs

@HimanshuChhabra
Copy link
Member

/azp run

Copy link

Commenter does not have sufficient privileges for PR 29175 in repo Azure/azure-rest-api-specs

@HimanshuChhabra
Copy link
Member

/pr RequestMerge

@microsoft-github-policy-service microsoft-github-policy-service bot added the MergeRequested Part of the ARM PR review workflow label May 29, 2024
@gary-x-li gary-x-li merged commit ce625c0 into Azure:main May 30, 2024
28 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review customer-reported Issues that are reported by GitHub users external to the Azure organization. MergeRequested Part of the ARM PR review workflow ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants