Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically generate version suffixes for private releases of DTFx.AS and DTFx.Core #918

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidmrdavid
Copy link
Collaborator

@davidmrdavid davidmrdavid commented Jun 22, 2023

When making a private extension release, we usually add a version suffix to the package so that it can be distinguished from an official release.

This PR automates that process so that the CI automatically adds a version suffix when the release pipeline is triggered in a feature branch. The version suffix will be -preview.<buildVersion> where <buildVersion> is automatically generated by the CI.

Since multiple groups work in this repo, I've only made this change for DTFx.AS and DTFx.Core. In order to achieve that, I created a copy of the release pipeline yaml and filtered it to only apply to those two packages.

@jviau
Copy link
Collaborator

jviau commented Jul 20, 2023

A lot of the MSBuild actions you are performing here are already part of the dotnet SDK. All we need is to set VersionPrefix and VersionSuffix. The SDK targets will handle concatenation (including the hyphen separator). I also recommend doing all the custom CI versioning tactics in MSBuild itself - I don't like relying on special CI scripts much.

You can see what I will be building towards for the Function's repos here: https://github.com/jviau/dotnet-worker-layout/tree/main/eng/targets in the Release.* files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants