Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade components to 0.99 and use golang for config processing #891

Open
wants to merge 146 commits into
base: main
Choose a base branch
from
Open

Upgrade components to 0.99 and use golang for config processing #891

wants to merge 146 commits into from

Conversation

rashmichandrashekar
Copy link
Contributor

PR Description

  1. Upgrade otelcollector and TA to 0.99
  2. Remove Prometheus-Operator custom build
  3. Use golang for configuration parsing instead of shell scripts
  4. Use golang exe as the main exe for container start
  5. Configure liveness probe from configuration-reader sidecar to accommodate removal of hot reload
  6. Web handler changes to work with latest version

New Feature Checklist

  • List telemetry added about the feature.
  • Link to the one-pager about the feature.
  • List any tasks necessary for release (3P docs, AKS RP chart changes, etc.) after merging the PR.
  • Attach results of scale and perf testing.

Tests Checklist

  • Have end-to-end Ginkgo tests been run on your cluster and passed? To bootstrap your cluster to run the tests, follow these instructions.
    • Labels used when running the tests on your cluster:
      • operator
      • windows
      • arm64
      • arc-extension
      • fips
  • Have new tests been added? For features, have tests been added for this feature? For fixes, is there a test that could have caught this issue and could validate that the fix works?

bragi92 and others added 30 commits April 1, 2024 13:20
@bragi92
wip
44a79be
@bragi92
Merge branch 'main' into kaveesh/step_1
1822946
@rashmichandrashekar
upgrade otelcollector
d3b8b0a
@rashmichandrashekar
update allocator and remove prom-operator
87dffc3
@rashmichandrashekar
update instructions
fa8d56b
@rashmichandrashekar
update go mod and go sum for ta
a38df13
@rashmichandrashekar
update go version in build
b774312
@rashmichandrashekar
updating golang version for build
488ac55
@rashmichandrashekar
use right golang version
8c3fa48
@rashmichandrashekar
Revert "use right golang version"
c903f1f 
This reverts commit 8c3fa48.
@rashmichandrashekar
adding only golang version
e65e2e6
@rashmichandrashekar
using base image and adding debug logs
e74e78c
@rashmichandrashekar
adding collectorselector
55ddd7d
@rashmichandrashekar
update config type
fe1e88f
@rashmichandrashekar
adding logs
1e72514
@rashmichandrashekar
fix
9c31489
@rashmichandrashekar
bug fix
48b723d
@rashmichandrashekar
adding busybox
4628e8f
@rashmichandrashekar
fixing build
2f57fcd
@rashmichandrashekar
updating build
2b0a164
@rashmichandrashekar
disabling filtering
bbbba1f
@rashmichandrashekar
fixing label selector
6135ad7
@rashmichandrashekar
updating filter strategy
b1b12d1
@rashmichandrashekar
updating cofnig reader
f217f55
@rashmichandrashekar
fix type
caf9830
@rashmichandrashekar
commenting fix
163c11c
@rashmichandrashekar
test
2420caf
@rashmichandrashekar
adding right log
7a2bdfd
@bragi92
wip
e23238d
@rashmichandrashekar
removing comments
3b4611b
@rashmichandrashekar rashmichandrashekar requested a review from a team as a code owner May 20, 2024 18:43
rashmichandrashekar
rashmichandrashekar commented May 23, 2024
View reviewed changes
otelcollector/build/linux/Dockerfile
@@ -8,45 +8,78 @@ RUN apt-get update && apt-get install gcc-aarch64-linux-gnu -y
ARG TARGETOS TARGETARCH
RUN if [ "$TARGETARCH" = "arm64" ] ; then CC=aarch64-linux-gnu-gcc CGO_ENABLED=1 GOOS=$TARGETOS GOARCH=$TARGETARCH go build -buildmode=c-shared -ldflags '-extldflags=-Wl,-z,now' -o out_appinsights.so . ; else CGO_ENABLED=1 GOOS=$TARGETOS GOARCH=$TARGETARCH go build -buildmode=c-shared -ldflags '-extldflags=-Wl,-z,now' -o out_appinsights.so . ; fi

FROM --platform=$BUILDPLATFORM mcr.microsoft.com/oss/go/microsoft/golang:1.20 as otelcollector-builder
FROM --platform=$BUILDPLATFORM mcr.microsoft.com/oss/go/microsoft/golang:1.21 as otelcollector-builder
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VIshwa - Remove ruby

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove ruby files. Test telemetry

rashmichandrashekar
rashmichandrashekar commented May 23, 2024
View reviewed changes
otelcollector/build/linux/Dockerfile
ARG TARGETOS TARGETARCH
RUN if [ "$TARGETARCH" = "arm64" ] ; then CC=aarch64-linux-gnu-gcc CGO_ENABLED=1 GOOS=$TARGETOS GOARCH=$TARGETARCH go build -buildmode=pie -ldflags '-linkmode external -extldflags=-Wl,-z,now' -o promconfigvalidator . ; else CGO_ENABLED=1 GOOS=$TARGETOS GOARCH=$TARGETARCH go build -buildmode=pie -ldflags '-linkmode external -extldflags=-Wl,-z,now' -o promconfigvalidator . ; fi

FROM --platform=$BUILDPLATFORM mcr.microsoft.com/oss/go/microsoft/golang:1.19 as main-builder
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update golang to 1.21

bragi92
bragi92 reviewed May 23, 2024
View reviewed changes
otelcollector/scratch/go_build.ps1
@@ -0,0 +1 @@
go build ./main/main.go ./shared/*.go ./shared/mp/*.go -o main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bragi92 bragi92 bragi92 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rashmichandrashekar @bragi92 @gracewehner