Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/update to chrome 118 #29

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix/update to chrome 118 #29

wants to merge 3 commits into from

Conversation

xWiinterphora
Copy link

Make the generator work with chrome version 118:

  • Add support for FilterEntry.
  • Fixed a bug with OpenSessionConnection not waiting until the socket has opened. This has sometimes caused issues for me during testing with many open chrome browsers.
  • Switch to using flattened mode instead of the deprecated (and possibly no longer functional) non-flattened mode. The SendCommand and Subscribe methods now have a parameter to provide a sessionId, which is blank ("") by default to provide backwards compatibility. A blank sessionId sends the command or subscription to the target of the websocketdebuggerurl, otherwise it will send it to the target with the given sessionId. You get a sessionId by attaching to a target, which will return one. From my testing, everything seems backwards compatible but I believe some things may not be. You can read more here https://github.com/aslushnikov/getting-started-with-cdp/blob/master/README.md

@xWiinterphora
fix: Fixes OpenSessionConnection at times not waiting until socket is…
0d56428 
… open because the event is never reset after it has been previously opened.
@xWiinterphora
feat: Add support for FilterEntry.
8bf4d64
@xWiinterphora
feat!: Switch to using flattened mode instead of the deprecated (and …
5023d08 
…I believe now non-functional) non-flattened mode. Read more at the link below.

BREAKING CHANGE:
It may break some things, but so far I've not encountered any backwards compatability issues. As long as a blank sessionId is provided for commands and event subscriptions (which it does by default if the sessionId parameter is not set), everything should work as before.

https://github.com/aslushnikov/getting-started-with-cdp/blob/master/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@xWiinterphora