Config for Soundfont, Font and "Focus Lost"

[Ghabry]

Pause when focus lost is now a setting, not a compile time option:

More Audio options

Information about MIDI drivers

The soundfont can be selected

Font configuration with preview:

[fdelapena]

nit: two spaces before ".png"

[Mimigris]

I know that it is still WIP but here's what I found in terms of issues while testing:

• The Pause when focus lost text changed since the picture that you sent and is now too long to properly fit on-screen (a custom font is used here but it's also the case with the default font)
  

• The MIDI Drivers menu seems to be laggy when selecting an option if no MIDI has been played during the current session and in some other occasions (e.g. game browser menu - the lag also occurs when selecting > Information < even if it doesn't do anything outside of playing a sound)

• The MIDI Drivers menu falsely report Native MIDI as Not working if attempted to be used in-game (tested with the Windows x64 version - the setting work as intended outside of that, it's just the display in the menu that is incorrect) with a warning too long to be displayed and read
  

• Unlike changing MIDI Drivers, changing the soundfont on the fly with the setting menu will not change it without reloading the game, which can be annoying to properly test

• If you want to change the size of the font currently being used, you need to change the size and then reselect the entry, you cannot just change the size to see and apply the changes, which is a bit annoying

• Since the font change is directly applied once a new character has been rendered, you can change it while displaying a message to have a message with different character sets, as well as having an incorrect spacing being used: it doesn't seem to cause gameplay issues since it only impacts the current message and doesn't change anything in terms of gameplay so I don't think that it's a huge problem
  

• In the MIDI Drivers menu, the text at the bottom of the screen will use the font from the last font previewed in the font menu, even if said font was not set
  

• Exiting a game that uses a custom font will still disallow you to change it even outside of it (in the game browser or in a game that doesn't use a specific font)
  

• The <Open (Sound)Font directory> should not be present on platforms where it is not possible to open a directory directly (e.g. Wii)

• On Wii (a platform where Fluidsynth is replaced by FluidLite), the option Fluidsynth is present and doesn't work, meaning that only FMMidi and WildMidi can be used there

• When Pause when focus lost is disabled, if the window of the game is put in the background, the Mouse Scroll Up/Down keys can still be used if the cursor is over the window of the game and the mouse position is still tracked Won't fix

Now more on a feedback side, feel free to take that into account or not:

• Disabling all MIDI entries display a "Couldn't play BGM music.mid. Format not supported" warning (that's intended), but if possible, maybe it could be better to specify that no MIDI entry is available instead in said case
• If I remember correctly, there is a thing on the RPG_RT where the two fonts used are not the same depending on the region/encoding, maybe having something to reverse the fonts used (either as a toggle directly in the menu or automatically depending on the encoding) could be used
• Having the possibility to maybe add an X number of pixels after a character could be useful for some fonts where all of the letters are sticked together, making them unreadable

Also, the webplayer doesn't seem to like the entries Open Font/Sound directory and seems to randomly crash outside of that, I'm not entirely sure why for the second part.

[Ghabry]

Thanks for the exhaustive testing. I won't respond to all but they all sound reasonable.

The Pause when focus lost text changed since the picture that you sent and is now too long to properly fit on-screen (a custom font is used here but it's also the case with the default font)

Hm I already fixed this one locally, maybe forgot to commit it.

But yeah some messages do not fit. I think about implementing a "scrolling" feature that scrolls the text back and forth so the rest is visible.

Unlike changing MIDI Drivers, changing the soundfont on the fly with the setting menu will not change it without reloading the game, which can be annoying to properly test

Yeah I would prefer to have some kind of "hot reloading" here so the audio changes immediately. I just couldn't find a way yet that does not crash xD.

Having the possibility to maybe add an X number of pixels after a character could be useful for some fonts where all of the letters are sticked together, making them unreadable

Good idea. This is already required for StringPic so can be exposed.

[Ghabry]

Instead of "Open (Sound)Font" emscripten got now "Upload (Sound)Font".

Can already see certain game developers demanding that this is patched out but not my problem :P

https://easyrpg.org/play/pr3168

Note that live switching between two MIDI devices (e.g. FmMidi to Fluidsynth) is not supported. Such a change requires playing a new MIDI file.

[Ghabry]

@florianessl it is not perfect yet but give it a try:

EDIT: Offset calculation for the mask is now correct

---

But this is now the final final contribution to this PR ;)

[Ghabry]

This is now ready in case somebody wants to do final testing.

---

The font stuff needs some Android Ui support imo but I will do this in another PR together with the LZH archive support. As you know I hate Android dev so I always do everything in one go 😅

[Ghabry]

(Rebased). I give one more week for feedback. Then going to merge this.

[Mimigris]

Changing the volume of the MIDI currently being played in the settings while having the MIDI output set as FluidSynth or FMmidi will not work entirely, since when reloading the music it seems that the volume set is different (tested with the title screen of Wadanohara and the Great Blue Sea - I suspect that the percentage of the volume is relative compared to the percentage that was set in the options when the music started for those two, = if a music starts while your setting is at 10%, the music almost cannot be heard in the end).

[Ghabry]

The MIDI volume issue is fixed now. Forgot that the path where I adjusted the volume is used by all MIDI code, not just MidiOut. The volume does still not perfectly match though. Good enough imo.

Also this took me faaaar too long to figure out (2 hours -_-) but I finally solved this "pop" issue you get when only using MIDI out for BGM and a sound effect ends...

[jetrotal]

After reading about the stretch settings in the code, got curious about something:

The stretch only works horizontally?
Shouldn't consider the vertical borders of the window as well?

[Ghabry]

This only stretches vertically because it was initially invented for Android. When you stretch in both directions it will look very interesting in Portrait orientation. :)

[Ghabry]

not commited yet as it depends on the other Android PR.

Had to disable the Settings Scene for Fluidsynth Soundfonts and Text Fonts on Android because the normal Player code cannot handle these URI-encoded SAF paths (because they use %2F as delimiter, not / -_-).

But here is the better workaround

[Ghabry]

Will merge this on Sunday when no further issues arise as this is slowly becoming a blocker for my other PRs.