-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Command 2056 - Spawn Map Event #3218
base: master
Are you sure you want to change the base?
New Command 2056 - Spawn Map Event #3218
Conversation
Command that clones Events from any map inside the current map. Co-Authored-By: Primekick <thetrueaxer@gmail.com>
This command looks pretty straight forward and simple to review. The only optimisation I see is that it shouldn't fetch and retranslate the map again when the map ID is the same as the active map. Maybe also consider "map 0" as the current map? (otherwise you need an additional event call to grab the ID). And maybe a small test game would be good that spawns an event in two ways:
Because I have to add the Web Player Async stuff, so I have directly something for testing... |
Ok, later tonight I'll poke around to fit map0 and mapItself cases. |
This delete event should be a separate command. It is also much harder than spawn because the semantics are unclear: what is supposed to happen with the interpreter execution (e.g. when having a parallel process running) of the deleted event when:
This must be will defined. For spawn this is obvious: refresh everything, done. Delete has multiple ways to do it. |
977c5ad
to
b87cafd
Compare
Updates on DestroyMapEvent You can also replace an older event with a new one with this optional parameter
b87cafd
to
278e2e4
Compare
Command that clones Events from any map inside the current map.
The syntax always comes in pairs. The first parameter of each pair indicates whether you are using a direct value or a variable/indirect variable, through ValueOrVariable().
Syntax (TPC):