IR-2070-fix-transform-editor-reactivity #10166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielBelmes
requested review from
MichaelEstes,
HexaField,
dinomut1 and
AidanCaruso
|
annoying test failures occuring |
HexaField
requested changes
May 16, 2024
packages/editor/src/components/properties/TransformPropertyGroup.tsx
Outdated
Show resolved
Hide resolved
HexaField
approved these changes
Jun 7, 2024
MbfloydIR
added a commit
that referenced
this pull request
Jun 10, 2024
* dev: migrate prefab list (#10329) display gizmo shortcut keys on hover (#10355) Fixed migration IR-48 Created a Tailwind AutoComplete component and updated Radio Component (#10254) fix directional and spot light additon (#10339) Fixed linting Restored getProjectEnv to return object instead of array Changes to move project-setting into a separate table (#10337) fixing context menu position (#10349) Added k8s-job-helper (#10335) IR-2070-fix-transform-editor-reactivity (#10166) Granular testing actions (#10327)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refrence .value of pos,rot,scale. We don't proxify matrix or matrix world so they weren't triggering hookstate updates
Subtasks Checklist
Breaking Changes
References
IR-2030
IR-2070
QA Steps