Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR-2057] Unit Tests: Hierarchy EntityTree.tsx #10174

Merged
merged 8 commits into from
Jun 5, 2024

Conversation

heysokam
Copy link
Contributor

@heysokam heysokam commented May 16, 2024

Summary

  • useChildWithComponent
  • useAncestorWithComponent

Subtasks Checklist

Breaking Changes

References

QA Steps

@heysokam heysokam marked this pull request as ready for review May 16, 2024 22:43
@DanielBelmes
Copy link
Contributor

@heysokam looks like tests are failing

@heysokam
Copy link
Contributor Author

@heysokam looks like tests are failing

@DanielBelmes I believe the branch was on an older dev where tests where failing
I just merged latest dev and it seems to be passing now ✍️

@DanielBelmes DanielBelmes dismissed HexaField’s stale review June 4, 2024 22:53

dismissing for rereview because I dislike how github doesnt remove this

@heysokam
Copy link
Contributor Author

heysokam commented Jun 5, 2024

@DanielBelmes Should we merge it, or is something else needed?

@heysokam heysokam force-pushed the IR-2057-unit-test-hierarchy-entity-tree-tsx branch from f4b478e to 76e9117 Compare June 5, 2024 07:49
@DanielBelmes DanielBelmes merged commit b5c1d4c into dev Jun 5, 2024
12 of 13 checks passed
@DanielBelmes DanielBelmes deleted the IR-2057-unit-test-hierarchy-entity-tree-tsx branch June 5, 2024 18:09
MbfloydIR added a commit that referenced this pull request Jun 7, 2024
* dev:
  Various Studio Bug Fixes (#10323)
  fix audio and media node editors (#10338)
  ability to drag drop in viewport and from asset panel (#10336)
  Michael/ir 1983 registry - Post Processing and Highlight (#10313)
  Updated Twitter/Facebook naming to X/Meta (#10065)
  fix thumbnail generation not proceeding for images and videos remove url from resources.json serialization
  Fix Thumbnail Generation (#10319)
  fixing minification warnings and fixing profile button style (#10340)
  Fix Image Compression Settings (#10283)
  IR-2532: Update Checkbox UI (#10322)
  remove extra transactions (#10331)
  IR-2225 Asset Loading Tech Debt (#10296)
  feat(assets): update styles [IR-2272] (#10318)
  Removed font.css, replaced with meta tag imports in components (#10328)
  background important (#10325)
  Fix Minio dimage failures (#10333)
  [IR-2053] Unit Tests: Core All ECS Hooks/Reactors (#10185)
  [IR-2057] Unit Tests: Hierarchy `EntityTree.tsx` (#10174)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants