[IR-2053] Unit Tests: Core All ECS Hooks/Reactors #10185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HexaField
reviewed
May 22, 2024
HexaField
requested changes
May 22, 2024
As per review: - Leftover console.log calls removed - InitialValue checks swapped with `undefined` and a `counter` variable For Types readability: - Change type casts to use a `ResultType` that unions undefined with the expected returned type
|
Has conflicts @heysokam. Though I'm not sure how they got there since this PR creates the file |
DanielBelmes
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Preliminary approval. Still pending integration with @speigg tests he wrote for immedieteUseEffect.
@DanielBelmes Should be good to go now ✍️ |
MbfloydIR
added a commit
that referenced
this pull request
Jun 7, 2024
* dev: Various Studio Bug Fixes (#10323) fix audio and media node editors (#10338) ability to drag drop in viewport and from asset panel (#10336) Michael/ir 1983 registry - Post Processing and Highlight (#10313) Updated Twitter/Facebook naming to X/Meta (#10065) fix thumbnail generation not proceeding for images and videos remove url from resources.json serialization Fix Thumbnail Generation (#10319) fixing minification warnings and fixing profile button style (#10340) Fix Image Compression Settings (#10283) IR-2532: Update Checkbox UI (#10322) remove extra transactions (#10331) IR-2225 Asset Loading Tech Debt (#10296) feat(assets): update styles [IR-2272] (#10318) Removed font.css, replaced with meta tag imports in components (#10328) background important (#10325) Fix Minio dimage failures (#10333) [IR-2053] Unit Tests: Core All ECS Hooks/Reactors (#10185) [IR-2057] Unit Tests: Hierarchy `EntityTree.tsx` (#10174)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
useAllComponentsSubtasks Checklist
Breaking Changes
References
QA Steps