Skip to content

Commit

Permalink
groq-builder: fixed build issues (#260)
Browse files Browse the repository at this point in the history
* feature(build): fixed build issues

* feature(build): ensure groq-builder gets built in CI

---------

Co-authored-by: scottrippey <scott.william.rippey@gmail.com>
  • Loading branch information
scottrippey and scottrippey committed Jan 25, 2024
1 parent ca16f28 commit 22e5dd3
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/static-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ jobs:

- name: Build library
run: pnpm run build:lib

- name: Type Check
run: pnpm run typecheck

- name: Lint
run: pnpm run lint
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"typecheck:shared": "tsc --project tsconfig.shared.json --noEmit",
"typecheck": "pnpm run typecheck:shared && pnpm run -r typecheck",
"check:ci": "pnpm run typecheck && pnpm run lint && pnpm run test",
"build:lib": "pnpm run --filter groqd build",
"build:lib": "pnpm run --filter groqd --filter groq-builder build",
"build:packages": "pnpm run --filter groqd --filter groqd-playground build",
"build": "pnpm run -r build",
"changeset": "changeset",
Expand Down
3 changes: 2 additions & 1 deletion packages/groq-builder/src/commands/select$.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ GroqBuilder.implement({
"When using 'select', either all conditions must have validation, or none of them. " +
`Missing validation: "${missing.join('", "')}"`
);
Error.captureStackTrace(err, GroqBuilder.prototype.select$);
// This only works on V8 engines:
(Error as any).captureStackTrace?.(err, GroqBuilder.prototype.select$);
throw err;
}

Expand Down
5 changes: 4 additions & 1 deletion packages/groq-builder/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
{
"extends": "../../tsconfig.json"
"extends": "../../tsconfig.json",
"compilerOptions": {
"target": "ES2019",
}
}

0 comments on commit 22e5dd3

Please sign in to comment.