Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop using node 16 in pipelines / clear other pipeline warnings #1324

Merged
merged 11 commits into from
Mar 12, 2024

Conversation

Burnett2k
Copy link
Member

@Burnett2k Burnett2k commented Mar 11, 2024

Description

As directed by Cb, we're no longer supporting node16, and will likely not use node matrixes anymore to build / test various node versions.

This pr removes usage of node 16 and matrix, as well as works to clean up some warnings due to using older versions of Github actions such as setup-node and actions/cache etc.

Fixes #1322 & #1323

ci.yml

Before updating ci.yml (lots of warnings):

image

After updating ci.yml (no warnings):

image

create-spectacle.yml

before:

image

after:

image

release.yml

before:

image

after:

release isn't ran until a merge / push is made to master, so I cannot obtain a screenshot of the results without doing some trickery. If needed I can do so, but the changes are essentially the same as the other two files, so seems probably unnecessary.

Type of Change

  • Chore / tech debt cleanup

How Has This Been Tested?

  1. I verified in the pipelines that the pnpm cache path is still retrieved and set correctly, and warnings were removed
  2. I built and ran all the sample applications locally

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run pnpm run check:ci and all checks pass
  • My changes generate no new warnings

Copy link

changeset-bot bot commented Mar 11, 2024

⚠️ No Changeset found

Latest commit: 15158c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spectacle-docs-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 2:44pm

@Burnett2k Burnett2k changed the title stop using node 16 stop using node 16 in pipelines / clear other pipeline warnings Mar 11, 2024
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Burnett2k Burnett2k marked this pull request as ready for review March 11, 2024 20:51
rely on default values
@Burnett2k Burnett2k merged commit 1dd3a89 into main Mar 12, 2024
5 checks passed
@Burnett2k Burnett2k deleted the issue/remove-ci-warnings branch March 12, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spectacle: ensure actions use node18
2 participants