Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update evaluate.py #1930

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update evaluate.py #1930

wants to merge 1 commit into from

Conversation

natedem30
Copy link

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)

Copy link

sentry-io bot commented May 15, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: giskard/rag/evaluate.py

Function Unhandled Issue
evaluate LLMGenerationError: Error while evaluating the agent main in <mod...
Event Count: 4
evaluate NameError: name 'domain' is not defined src.modul...
Event Count: 2
evaluate NameError: name 'doc_chat' is not defined _main...
Event Count: 1
evaluate NameError: name 'domain' is not defined main ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@kevinmessiaen
Copy link
Member

Hello @natedem30

Thanks for the contribution. It look like the goal if the PR is to refactor the code. Would it be possible from you to update the PR tittle and description? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants