Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to web-vitals v4 #856

Merged
merged 3 commits into from
May 20, 2024
Merged

Upgrade to web-vitals v4 #856

merged 3 commits into from
May 20, 2024

Conversation

rviscomi
Copy link
Member

Upgrades to web-vitals@4.0.0 and makes necessary compatibility changes:

  • remove expired LoAF origin trial token
  • remove obsolete LoAF properties
    • script.sourceLocation
    • script.type
  • stop manually collecting LoAF entries and use the entries provided by web-vitals
  • stop manually calculating three delay/processing phases and use the times provided by web-vitals
  • add script-specific forced style and layout duration metric
  • update properties renamed in v4
    • eventType —> interactionType
    • eventTime —> interactionTime
    • eventTarget —> interactionTarget

@rviscomi rviscomi requested a review from tunetheweb May 15, 2024 14:26
@rviscomi rviscomi mentioned this pull request May 15, 2024
Closed
tunetheweb
tunetheweb approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one tiny nit on the comment

src/js/send-web-vitals.js Outdated Show resolved Hide resolved
@rviscomi @tunetheweb
Update src/js/send-web-vitals.js
da1cd1f 
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
@rviscomi rviscomi merged commit f06d163 into main May 20, 2024
4 checks passed
@rviscomi rviscomi deleted the wv4 branch May 20, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunetheweb tunetheweb tunetheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rviscomi @tunetheweb