Feature: Shared model definitions #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…multiple connections.
Ensure that models which did not have a connection defined and are being associated with the default datasource do not have their connection property set.
Configures a second database for supporting multiple datasources.
Allows removing other logic involving checking for reconciling if the default datasource has not yet been run when exporting models to globals.
Simplifies creating associations.
|
Seems that this work is not finished yet... |
|
I'm looking at why the tests succeed locally but fail in travis. |
|
I've refactored tests heavily. So, please, pull updates from master into your code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
Adds support for sharing model definitions between multiple sequelize datasources automatically.
What is the current behavior?
Models can only be created for a single datasource at a time.
What is the new behavior?
When multiple datasources are configured and the
config/sequelize.jspropertyshareModelsAmongConnectionsistrue, any models where theconnectionproperty is not explicitly set will be added to all sequelize connections.Additionally, if sails models are configured to expose models globally, the shared models can be access through the global model class through a property with the same name as the associated datasource. e.g.
Model[datasourceName].someMethod()What kind of change does this PR introduce?
Checklist: