Fix deprecation warnings and increase deployment target to 10.13 for Xcode 14 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix deprecation warnings
|
Can you edit your title to say 10.13 instead of 10.3? Thank you |
ksuther
changed the title
Coeur
reviewed
Aug 28, 2023
| @@ -1142,7 +1142,7 @@ - (void)_installEventHandlerIfNeeded | |||
| { kEventClassKeyboard, kEventHotKeyPressed }, | |||
| { kEventClassKeyboard, kEventHotKeyReleased } | |||
| }; | |||
| os_trace("Installing Carbon hot key event handler"); | |||
| os_log_error(OS_LOG_DEFAULT, "Installing Carbon hot key event handler"); | |||
There was a problem hiding this comment.
This one shouldn't be an error, I believe.
Coeur
reviewed
Aug 28, 2023
| @@ -1167,11 +1167,11 @@ - (void)_removeEventHandlerIfNeeded | |||
| if (_disableCounter <= 0 && _shortcutToHotKeyRef.count) | |||
| return; | |||
|
|
|||
| os_trace("Removing Carbon hot key event handler"); | |||
| os_log_error(OS_LOG_DEFAULT, "Removing Carbon hot key event handler"); | |||
There was a problem hiding this comment.
This one shouldn't be an error I believe.
Coeur
reviewed
Aug 28, 2023
| return; | ||
| } | ||
|
|
||
| static UInt32 CarbonID = _SRInvalidHotKeyID; | ||
| EventHotKeyID hotKeyID = {SRShortcutActionSignature, ++CarbonID}; | ||
| os_trace("Registering Carbon hot key"); | ||
| os_log_error(OS_LOG_DEFAULT, "Registering Carbon hot key"); |
Coeur
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149
I replace
os_tracewithos_logwhich causes a lot more logging in Xcode, but preserves the logging.os_log_debugis too chatty for my taste, but I didn't want to be deleting existing logging either.