Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Sync): Display errors on sync branches modal #7433

Merged
merged 1 commit into from
May 20, 2024

Conversation

gatzjames
Copy link
Contributor

Currently errors are not displayed properly inside the modal for syncing branches.

Highlights:

  • Adds proper error handling

Next steps:

  • Move the branches modal functionality in the sidebar to improve UX as alerts on top of a modal are creating a lot of friction

Closes INS-3850

@gatzjames gatzjames self-assigned this May 20, 2024
@gatzjames gatzjames requested a review from a team May 20, 2024 08:03
Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this use effect idle checker pattern is smelly and error prone, is there any hope of something better?

@gatzjames
Copy link
Contributor Author

this use effect idle checker pattern is smelly and error prone, is there any hope of something better?

React 19/router v7 will have the new actions api which will remove all this dependency management. Currently not sure if there's a better approach

@gatzjames gatzjames merged commit 258810e into Kong:develop May 20, 2024
7 checks passed
@gatzjames gatzjames deleted the fix/sync-modal-error-warnings branch May 20, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants