Move Actions concurrency limits to the build step #3183
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR?
Enhancement
What does this PR do?
This lays the groundwork for a cron workflow to rebuild nightly in order to get security updates. I considered trying to just add a schedule trigger to multiarch.yml, but schedule only supports the default branch as
github.ref
which gets irritating because anywhere that usesgithub.ref
now has to fall back to another value if the workflow was triggered by a schedule. It's much easier to just add another workflow andNote that there is technically now a race here because GitHub doesn't guarantee ordering of jobs within a concurrency group, so in theory if commit B got merged very shortly after commit A, and commit B's multiarch run was super slow for some reason, commit A might end up preempting it. However AFAICT this is basically impossible in practice because Bors will properly serialize merges. This is the reason we remove concurrency control from multiarch.yml.
I enabled
cancel-in-progress
since it just kinda seemed like we might as well - if we let the build finish, it'll just be overwritten in a few minutes anyway.Related issue(s)
None AFAIK
Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.