-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Priority in Broken Rule #3945
Added Priority in Broken Rule #3945
Conversation
…he-rule-in-the-BrokenRuleType/main
…he-rule-in-the-BrokenRuleType/main
…he-rule-in-the-BrokenRuleType/main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rockfordlhotka The changes are okay for me. But please double check if it's what was intended with the associated issue. Thanks
I added the BreakingChange tag to the original issue, as this does change the behavior of existing methods. Beyond my one request for a potential code change, I like the changes being made here. |
…he-rule-in-the-BrokenRuleType/main
Is this any changes required here? If not Can you please merge this PR? |
…he-rule-in-the-BrokenRuleType/main
@rockfordlhotka Please approv so lgtm :) |
-Updated 'GetFirstBrokenRules()' in BrokenRulesCollection, this method will return 'first' broken rules for the object (or object graph).
-Added Priority to
BrokenRule.cs
Fixes #3224