Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance M115 with additional capabilities and a temperature report #26869

Open
wants to merge 8 commits into
base: bugfix-2.1.x
Choose a base branch
from

Conversation

Sophist-UK
Copy link
Contributor

Description

Enhance the M115 command with additional capabilities reports and a new Temperature report

Requirements

No.

Benefits

Improved reporting of capabilities for use by e.g. Octoprint.

Configurations

Uncomment the #define M115_TEMPERATURE_REPORT at line 3922 in Configuration_adv.h.

Related Issues

Matches capabilities for Dagoma DiscoUltimate v2 TMC stock firmware.

"}"
);
#endif

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marlin supports up to 8 hotends as well as a chamber, so they should be accounted for as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the other devices with temperatures? You still have TEMP_SENSOR_PROBE, TEMP_SENSOR_CHAMBER, TEMP_SENSOR_COOLER, TEMP_SENSOR_BOARD, TEMP_SENSOR_SOC, and TEMP_SENSOR_REDUNDANT.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I will add these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only CHAMBER has MIN and MAX temps in addition to hotends and bed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only CHAMBER has MIN and MAX temps in addition to hotends and bed.

They're just not in the same place. Example:

#define SOC_MAXTEMP 85 // (°C)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cooler and Board have both. SOC has only max temp. Redundant / Probe have neither.

@Sophist-UK
Copy link
Contributor Author

I quite like the DIRECT_DRIVE determination, but I will have to see how this can work in a way that doesn't fail tests.

@thisiskeithb
Copy link
Member

I quite like the DIRECT_DRIVE determination, but I will have to see how this can work in a way that doesn't fail tests.

Smaller bowden machines would also fall into the "FILAMENT_CHANGE_UNLOAD_LENGTH < 100" area, so you can't rely on unload length.

@Sophist-UK
Copy link
Contributor Author

Smaller bowden machines would also fall into the "FILAMENT_CHANGE_UNLOAD_LENGTH < 100" area, so you can't rely on unload length.

Hmmm - just how small can a bowden tube go in practical terms? 100mm is only 4" and since a bowden tube has to stretch between a fixed extruder and a head at the furthest extreme, if it were less than 4" in length the build volume would be < 2" which is pretty darn small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants