resolve #3174 by ensuring duration value is defined for updateNowPlaying #3476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r updateNowPlaying
|
💖 Thanks for opening this pull request! 💖 |
|
@MarshallOfSound Please let me know if there is anything more I can do to help release this change. |
rcp87
approved these changes
Mar 6, 2019
|
@MarshallOfSound I'd love to get this one merged when it looks good to you. |
|
@MarshallOfSound hi, any chance you have time for this PR now? |
jostrander
approved these changes
Oct 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses an issue that was preventing YouTube Music from scrobbling with last.fm.
At the time of the
change:trackevent, the duration of the track is not yet known. This PR proposes keeping some state inlastFM.jsto update the now playing status at the firstchange:playback-timeevent that contains a nonempty duration value.