-
-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataGrid: Dynamic data support through ExpandoObject #5507
Conversation
Well, I believe, this is it. What do you think? |
Friendly reminder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to create a separate test page in the Demo project. And also add unit test(s).
There are conflicts now. |
Done. |
@stsrki Friendly reminder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If you don't plan to add anything else I will merge it.
I am ok with the feature for now. Better have it introduced and get feedback from users using it then to overdo it. |
While it wasn't that hard to integrate the loading of data.
I found it might be a bit limited regarding the edit operations. This is because due to the dynamic nature, we can't really figure out the Type of a particular field without having an actual structure.
This means that when editing:
We need to infer from the actual item field type in order to know what input to render (numeric, checkbox, etc), so this means a nullable won't be easily figured out, if the value is null, there's no way you can tell which type would be in this particular field for example.
So the TypeGetter method was updated to include the Item as a parameter to look into it.
When creating:
We need to override the
NewItemCreator
and provide the structure so the Grid can figure out the inputs to render, checkboxes, numeric, etc...What are your thoughts?