This repository has been archived by the owner on Jan 22, 2022. It is now read-only.
Don't COW the internal this constant
#132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain ternary expressions could result in COWing the internal `this` constant unnecessarily. Mark `this` as constant to avoid this. Because this hides another bug, I've added a (currently failing) test that detects the more general case of inappropriate COWing across ternary operators. I've not added it to the scene because I'm sure the merge will be a nightmare (and it's failing until some of Merlin's working branch changes land)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain ternary expressions could result in COWing the internal
thisconstant unnecessarily. Mark
thisas constant to avoid this.Because this hides another bug, I've added a (currently failing) test that
detects the more general case of inappropriate COWing across ternary
operators. I've not added it to the scene because I'm sure the merge will
be a nightmare (and it's failing until some of Merlin's working branch
changes land)