MudTabPanel: Allow icon color to be set from panel

[djflan]

Description

Allows MudTab Icon Color to be set from MudTabPanel (override)

How Has This Been Tested?

Visually tested using the existing 'RippleTest'

Type of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation (fix or improvement to the website or code docs)

Checklist

• The PR is submitted to the correct branch (dev).
• My code follows the code style of this project.
• I've added relevant tests.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.63%. Comparing base (28bc599) to head (3ae482a).
Report is 242 commits behind head on dev.

❗ Current head 3ae482a differs from pull request most recent head 5569a1c

Please upload reports for the commit 5569a1c to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #9001      +/-   ##
==========================================
+ Coverage   89.82%   90.63%   +0.80%     
==========================================
  Files         412      398      -14     
  Lines       11878    12382     +504     
  Branches     2364     2406      +42     
==========================================
+ Hits        10670    11222     +552     
+ Misses        681      621      -60     
- Partials      527      539      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[danielchalmers]

Should it be Inherit instead of default like the original property?

MudBlazor/src/MudBlazor/Components/Tabs/MudTabs.razor.cs

Lines 137 to 142 in 1a68c71

	/// <summary>
	/// The color of the icon. It supports the theme colors.
	/// </summary>
	[Parameter]
	[Category(CategoryTypes.Tabs.Appearance)]
	public Color IconColor { get; set; } = Color.Inherit;

Also needs unit test

[henon]

@djflan Thanks for the PR, it is good to merge except there is no unit test which is our policy for PRs. The reason is that any feature that has a test can not be accidentally be undone or broken. It is the reason why the library is so stable despite hundreds of collaborators.

In your case, check that the color of the panel is used if unset and when set it overrides the color.

[djflan]

@djflan Thanks for the PR, it is good to merge except there is no unit test which is our policy for PRs. The reason is that any feature that has a test can not be accidentally be undone or broken. It is the reason why the library is so stable despite hundreds of collaborators.

In your case, check that the color of the panel is used if unset and when set it overrides the color.

Added a unit test. Seems tricky to get the color of the icon. I had to assign 'Color.Success' and check the SVG class list for 'mud-success-text'. currently unsure if there is another way to do this.

[dennisrahmen]

Hey not at my pc currently so could not test myself. Could you check if the icon is grayed out when the tab is disabled.

This should be the case if no specific color is set as well as when there is a color set for the tab or inherited as you added here.

If not you would need to pass down the "Disabled" property to the icon.

[djflan]

Hey not at my pc currently so could not test myself. Could you check if the icon is grayed out when the tab is disabled.

This should be the case if no specific color is set as well as when there is a color set for the tab or inherited as you added here.

If not you would need to pass down the "Disabled" property to the icon.

Added a check for disabled panel state and inherited color when disabled. Also added a unit test for this since I'm sure it will be requested.

[henon]

Thanks!