Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudMessageBox: Use ParameterState framework #9014

Merged
merged 1 commit into from
May 20, 2024

Conversation

ScarletKuro
Copy link
Member

Description

Get rid of BL0007
Rename Show to ShowAsync.

How Has This Been Tested?

Manually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added breaking change bug Something does not work as intended/expected PR: needs review labels May 19, 2024
@ScarletKuro ScarletKuro requested a review from henon May 19, 2024 13:17
Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.58%. Comparing base (28bc599) to head (390c0b4).
Report is 214 commits behind head on dev.

Files Patch % Lines
...lazor/Components/MessageBox/MudMessageBox.razor.cs 73.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9014      +/-   ##
==========================================
+ Coverage   89.82%   90.58%   +0.75%     
==========================================
  Files         412      394      -18     
  Lines       11878    12135     +257     
  Branches     2364     2366       +2     
==========================================
+ Hits        10670    10993     +323     
+ Misses        681      610      -71     
- Partials      527      532       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielchalmers
Copy link
Contributor

Thanks

@henon henon merged commit f94bb35 into MudBlazor:dev May 20, 2024
4 of 5 checks passed
@henon henon mentioned this pull request May 20, 2024
@ScarletKuro ScarletKuro deleted the MudMessageBox_param branch May 20, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants