Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudListItem, MudMenu, MudMenuItem: Format razor markup #9017

Merged
merged 4 commits into from
May 22, 2024

Conversation

danielchalmers
Copy link
Contributor

Description

This was a part of an abandoned PR that overhauled some of the click handling for #8977. Figured I would submit instead of throwing it away.

The risk in formats and refactors has always been the loss of history with git blame, but because all the properties were stacked on one line the history was very weak, but will be stronger from now on and make reviews easier.

But feel free to close if it's not a good idea.
 

How Has This Been Tested?

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.50%. Comparing base (28bc599) to head (d65c0aa).
Report is 222 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9017      +/-   ##
==========================================
+ Coverage   89.82%   90.50%   +0.67%     
==========================================
  Files         412      394      -18     
  Lines       11878    12139     +261     
  Branches     2364     2369       +5     
==========================================
+ Hits        10670    10987     +317     
+ Misses        681      620      -61     
- Partials      527      532       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielchalmers
Copy link
Contributor Author

danielchalmers commented May 20, 2024

Note: I'm not making any more standalone PRs for this kind of change. I just had already changed this code for something else.

@ScarletKuro ScarletKuro added the refactor Refactoring of code. No bug fixes or new features label May 21, 2024
@henon henon merged commit b2c80fa into MudBlazor:dev May 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: needs review refactor Refactoring of code. No bug fixes or new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants