Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure coil is not being simulated when speed == 0. #10407

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

tanaya-mankad
Copy link
Collaborator

@tanaya-mankad tanaya-mankad commented Feb 21, 2024

Pull request overview

  • Assuming that CoolingSpeedNum == 0 indicates that the equipment is not running, bypass Coil simulate function when that is the case.
  • Further work should review cases where speed is set to 0, and/or other indicators (member variables) that imply that the coil is "off"

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@tanaya-mankad tanaya-mankad added the Defect Includes code to repair a defect in EnergyPlus label Feb 21, 2024
@tanaya-mankad tanaya-mankad self-assigned this Feb 21, 2024
@tanaya-mankad tanaya-mankad changed the title Initialize Unitary m_CoolingSpeedNum to 1, not 0. Ensure coil is not being simulated when speed == 0. Feb 21, 2024
@Myoldmopar Myoldmopar added this to the EnergyPlus 24.2 milestone Mar 14, 2024
@nrel-bot
Copy link

@tanaya-mankad @Myoldmopar it has been 28 days since this pull request was last updated.

3 similar comments
@nrel-bot-2b
Copy link

@tanaya-mankad @Myoldmopar it has been 28 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@tanaya-mankad @Myoldmopar it has been 28 days since this pull request was last updated.

@nrel-bot
Copy link

nrel-bot commented Jun 7, 2024

@tanaya-mankad @Myoldmopar it has been 28 days since this pull request was last updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants