Correct WSHP constant fan operating mode

[rraustad]

Pull request overview

• Fixes ZoneHVAC:WaterToAirHeatPump air flow control issue #10486
• ZoneHVAC:WaterToAirHeatPump heating mode does not honor a constant fan operating mode schedule when a variable or multi-speed heating coil is used. When operating in cooling mode the constant fan operating mode works correctly.

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[rraustad]

This was the problem in the defect file. In heating mode, when constant fan is used, the OFF mass flow rate should be the same as the ON mass flow rate.

[rraustad]

This unit test should have noticed the issue with on and off air flow. This is correct now.

[rraustad]

Top row is from PackagedTerminalAirConditionerVSAS and bottom row is PackagedTerminalHeatPumpVSAS example files that show big diffs. The fan/airflow is now constant as expected. The VS coils model constant air flow at speed which may not be the best choice for constant fan operating mode but that's what these coils do now.