Fix FMU Variable Update

[mjwitte]

Pull request overview

• Fixes FMU running problem for v9.5 and newer #9315

• Somehow (likely during conflict resolution in Global Daylighting Manager, External Interface, Erl Processor #8619) UpdateDataDuringWarmupExternalInterface=true was commented out, which caused GetInternalVariableValueExternalInterface to return zeroes until warmup was complete. For the defect file, this caused an invalid calculation which resulted in a fatal error.

• The workaround is to turn on Output:Diagnostics, ReportDuringWarmup. Of course, this will add extra rows of output at the top of the eso/csv output, but at least the simulation will run to completion.

• Need a unit test and/or an integration test to catch this.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[Myoldmopar]

Oh sheesh. As I clicked through that old PR I saw extern everywhere....triggered. Anyway, thanks for this quick fix, I'm not sure what happened to cause it to be disabled, but great to have it fixed. I'll just merge this in as-is. Thanks @mjwitte