-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.7 (EOL) #4888
base: devel
Are you sure you want to change the base?
Drop Python 3.7 (EOL) #4888
Conversation
This is not the kind of change we can do without any sort of discussion. 60% of active OctoPrint installs still use Python 3.7 because that's the version on Debian Buster and they don't re-flash their OS that often. We definitely can't do this right now, and not without some kind of communication to users to upgrade their Python version. |
I understand. |
I converted this to draft status, since as already mentioned that is something we cannot currently merge, and it will be some time before that changes, during which this certainly will become outdated and require more work to be up-to-date again. Thank you in any case! |
to a large audience (ideally all users of OctoPrint)
made sure your changes don't interfere with current development by
talking it through with the maintainers, e.g. through a
Brainstorming ticket
devel
branch if it's a completelynew feature, or
maintenance
if it's a bug fix or improvement ofexisting functionality for the current stable version (no PRs
against
master
or anything else please)(no PRs from your version of
master
,maintenance
, ordevel
please), e.g.
dev/my_new_feature
orfix/my_bugfix
no dead code, ideally only one commit - rebase and squash your PR
if necessary!
.less
source files, not the.css
files (those are generatedwith
lessc
)have added unit tests
nothing broke
AUTHORS.md
file :)What does this PR do and why is it necessary?
Python 3.7 has reached its End of Life state.
It's no longer maintained.
Newer versions provide bug fixes and improvements that can make the code easier to maintain.
More information on Python versions lifecycle here:
https://devguide.python.org/versions/
How was it tested? How can it be tested by the reviewer?
Any background context you want to provide?
What's new in Python 3.8:
https://docs.python.org/3/whatsnew/3.8.html
What are the relevant tickets if any?
None
Screenshots (if appropriate)
The workaround for
datetime.fromtimestamp
is no longer needed.Further notes
Since the PR reduces the range of supported Python versions by OctoPrint, I'd consider this as breaking changes targeting next major version of the product (OctoPrint 2.0)