-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(php-nextgen): allow to serialize collections of enums #18549
base: master
Are you sure you want to change the base?
Conversation
When serializing collections, make sure to serialize the members of the collection first, before applying http_build_query or implode.
@SomeBdyElse thanks for the PR. what about adding a test or 2 in https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/php-nextgen/OpenAPIClient-php/test/ObjectSerializerTest.php ? please follow step 3 to update the samples as well. |
Hi @wing328 ! Thank you for looking at the PR. Unfortunately I do not have a Java development environment to build the project and examples. I might try https://github.com/OpenAPITools/openapi-generator?tab=readme-ov-file#development-in-docker . Is https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/php-nextgen/OpenAPIClient-php/test/ObjectSerializerTest.php the right file to create the tests? I thought that the entire |
these folder contains integration tests too so do not purge the whole folder when regenerating samples |
yes, please try that and let me know if you need any help. |
i've updated the samples locally, ran the tests and got some errors:
can you please take a look when you've time? |
When serializing collections, make sure to serialize the members of the collection first, before applying http_build_query or implode.
@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)