Fix no se muestran los expects #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlopezalvas
commented
Mar 15, 2024
| return this.experimentGroup() === "off" | ||
| return this.experimentGroup() === this.possibleGroups[3] |
There was a problem hiding this comment.
De paso cambié acá para tener el string en un solo lado
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No se estaban mostrando las expects en el modo
"off"del experimento, porque esto:pilas-bloques-ember/app/services/experiments.js
Lines 104 to 106 in c8ddf9b
El modal se muestra en el caso de que sea notAffected, y el chequeo de que fuera not affected estaba sin considerar el 'off':
pilas-bloques-ember/app/services/experiments.js
Lines 29 to 31 in c8ddf9b