New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error when using pnp in strict mode due to undeclared dependencies #497
Comments
@Quramy This plugin is AWESOME! do you plan to update it to support the mentioned above breaking change in dependency |
Any plan to have this fixed? Alternatively would you accept a PR? |
👍 |
@Quramy While the These are the last
Changing For example, with these newer dependencies:
Here a small repo: https://github.com/artola/typescript-eslint-language-service-issue.git While running the script
|
I tried to reproduce using your repos. I confirmed reproducing that there're no errors reported in VSC after installing TypeScript v5 and typescript-eslint-language-service v5.0.5 . However, ESLint errors are still reported to my editor(Vim). My Vim uses https://github.com/dense-analysis/ale and https://github.com/Quramy/tsuquyomi , they interact with tsserver. I don't know why only VSC can't report ESLint errors 🤔 |
@JoshuaKGoldberg could you please give us some hint about what could be the breaking change? |
I don't use If you think it's an issue with |
@Quramy If I update the dependencies to the latest:
I can see in the VSCode's
Then it is clear that the problem is about finding And "voilà" the solution is to tweak the
Now errors are properly display on VSCode. I hope this help other users. Thanks @Quramy for your support. CC @awydler |
@artola would you be able to explain how what you wrote relates to the issue I have reported? The issue is about dependencies imported by this module not being listed in it’s package.json |
@adrian-gierakowski Since version
There is another correlation between the dependencies and my findings. The problem is that as you mention, the semver as applied in version Now, if we move all the dependencies to the latests versions, everything works. At that point, pinning dependencies in the plugin is not needed, could be improved with a simple comment/warning in the |
@artola thats for taking the time to explain! I’ll try it out on my project with yarn berry once I’m back to work next week and report back if it works for me. |
https://hynek.me/articles/semver-will-not-save-you The change in typescript-eslint (typescript-eslint/typescript-eslint#5834) was an internal refactor that didn't change the public API. There's no reason why it would have been labeled as a breaking change. It's inaccurate to call it a breaking change. Please don't throw that shade at us. 😉 If typescript-eslint has a bug, then that's another story. Please file an issue on us. But: what is the actual behavior change in I tried cloning the repro repo, bumping |
@JoshuaKGoldberg Just set these dependencies and errors are not reported anymore (just change
Here the
About "breaking change" or not, it’s not you it’s me. 😉 Something breaks in this ecosystem at that point. Anyway, moving all the dependencies forward and changing the Then, the problem does not persist with the mentioned solution, and I don't know why this was affecting VSCode but not other solution as @Quramy mentioned above. |
for example:
This affects users of yarn 3 (berry) and https://pnpm.io when using pnp.
Here's a patch which I had to put in my
.yarnrc.yml
to make silence the errors, which shows the deps accessed by this module in an unsound manner:Note that I had to pin
@typescript-eslint/typescript-estree
to5.41.0
since5.42.0
introduced a breaking change which breakstypescript-eslint-language-service
The text was updated successfully, but these errors were encountered: