-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing guild incident fields #9808
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: owocado <24418520+owocado@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems mostly fine, but minor bikeshedding nit: methods checking for boolean stuff tend to have the is_
prefix, e.g. is_timed_out()
or is_on_mobile
, etc.
@@ -4435,3 +4457,23 @@ def dms_paused(self) -> bool: | |||
return False | |||
|
|||
return self.dms_paused_until > utils.utcnow() | |||
|
|||
def dm_spam_detected(self) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def dm_spam_detected(self) -> bool: | |
def is_dm_spam_detected(self) -> bool: |
|
||
return self.dm_spam_detected_at > utils.utcnow() | ||
|
||
def raid_detected(self) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def raid_detected(self) -> bool: | |
def is_raid_detected(self) -> bool: |
Summary
These new fields were added to the docs PR:
dm_spam_detected_at
raid_detected_at
I'm not sure if the
..._detected
methods are necessary...Checklist