Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public geojson endpoint #4670

Open
wants to merge 81 commits into
base: 4513-public-feed-2
Choose a base branch
from

Conversation

perryr16
Copy link
Contributor

@perryr16 perryr16 commented May 14, 2024

Any background context you want to provide?

What's this PR do?

  • Adds a public geojosn endpoint that leverages some functionality from the tax lot property export code
  • Limits fields returned to those set in org sharing and available gis data
  • Adds an org setting for public_geojson_enabled

How should this be manually tested?

With properties that have geo data like lat/long,

  1. Test with endpoints disabled. Go to org settings and unselect either "enable public endpoints" or "enable public geojson". Go to /api/v3/public/organizations/{org_id}/cycles/{cycle_id}/geo.json. The endpoints should return an error message

  2. Test with endpoints enabled. Go to /api/v3/public/organizations/{org_id}/cycles/{cycle_id}/geo.json. Copy the json response and paste into geojson.io. Map should show your seed properties

  3. Add query_param "?taxlots=true" to return only taxlots

What are the relevant tickets?

#4635

Screenshots (if appropriate)

Screenshot 2024-05-03 at 11 22 19 AM
Screenshot 2024-05-14 at 2 08 16 PM

@perryr16 perryr16 added the Feature Add this label to new features. This will be reflected in the change log when generated. label May 14, 2024
@perryr16 perryr16 mentioned this pull request May 14, 2024
@perryr16 perryr16 changed the base branch from develop to 4513-public-feed May 14, 2024 19:25
@perryr16 perryr16 marked this pull request as ready for review May 15, 2024 14:59
@perryr16 perryr16 requested a review from kflemin May 15, 2024 14:59
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be "Returns a GeoJSON with the fields defined in the Organization Sharing selections"?

image

When clicking on the "Organization Sharing" link in the "Enable Public Endpoints" description, it returns this:

image

Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous comment

@perryr16 perryr16 changed the base branch from 4513-public-feed to 4513-public-feed-2 May 28, 2024 20:25
@perryr16 perryr16 changed the base branch from 4513-public-feed-2 to 4513-public-feed-rebase May 29, 2024 15:33
@perryr16 perryr16 changed the base branch from 4513-public-feed-rebase to 4513-public-feed-2 May 29, 2024 15:34
@perryr16 perryr16 changed the base branch from 4513-public-feed-2 to 4513-public-feed-rebase May 29, 2024 15:35
@perryr16 perryr16 changed the base branch from 4513-public-feed-rebase to 4513-public-feed-2 May 29, 2024 15:46
@perryr16
Copy link
Contributor Author

Updated help text
Screenshot 2024-05-29 at 11 42 26 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Add this label to new features. This will be reflected in the change log when generated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants