Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Discord Rich Presence support #1027

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add Discord Rich Presence support #1027

wants to merge 7 commits into from

Conversation

ImUrX
Copy link
Member

@ImUrX ImUrX commented May 9, 2024

what have i made

@ImUrX ImUrX added Area: GUI Related to the GUI Type: Enhancement Adds or improves a feature labels May 9, 2024
@ImUrX ImUrX marked this pull request as ready for review May 10, 2024 04:46
@VocalFan
Copy link
Contributor

Oh damn, using the same Rust Cargo I used for Rich Presence on my project! Nice

VocalFan
VocalFan approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@VocalFan VocalFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust code seems good to me. Can anyone check the typescript half of the code?

@ImUrX ImUrX requested a review from Erimelowo as a code owner May 23, 2024 00:54
Erimelowo
Erimelowo requested changes Jun 5, 2024
View reviewed changes
Copy link
Member

@Erimelowo Erimelowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine and lgtm except for the text

gui/public/i18n/en/translation.ftl Outdated Show resolved Hide resolved
gui/src/hooks/discord-presence.ts Outdated Show resolved Hide resolved
@ImUrX @Erimelowo
Apply funny suggestions from fox
67f369d 
Co-authored-by: Erimel <marioluigivideo@gmail.com>
@ImUrX ImUrX requested a review from Erimelowo June 5, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erimelowo Erimelowo Erimelowo approved these changes

@VocalFan VocalFan VocalFan approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Area: GUI Related to the GUI Type: Enhancement Adds or improves a feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ImUrX @VocalFan @Erimelowo