-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing head tracker status #962
base: main
Are you sure you want to change the base?
Conversation
Haven't tested it yet! |
i tested it and it seems to work, status system is a little finicky in the GUI side, sometimes packets are lost, it should be solved someday tbh |
server.allTrackers | ||
.filter { !it.isInternal && it.trackerPosition != null } | ||
.forEach { | ||
// This can't be solved with a yaw reset, it requires a full reset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be solved with a yaw reset
fun checkTrackersRequiringReset() { | ||
// Checks if this is main human pose manager (having server) or | ||
// skeleton doesn't have a head tracker or not an HMD one | ||
// TODO: Should this be ran anyways if headTracker is null or is not an HMD? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It needs to be ran if headTracker is null (specifically when the previous headTracker was computed). Doesn't need to be ran if headTracker is not computed as IMU head trackers will be adjusted to Identity.
// TODO: Should this be ran anyways if headTracker is null or is not an HMD? | ||
if (server == null || | ||
skeleton.headTracker == null || | ||
skeleton.headTracker?.isHmd != true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably check for isComputed instead
skeleton.headTracker?.isHmd != true | |
skeleton.headTracker?.isComputed != true |
isHmd
flag inTracker
isHmd
trackers andheadTracker
in main skeleton is nullHumanSkeleton#headTracker
has changed