Open a test file for claw and learn how to use the debugger! #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply Sweep Rules to your PR?
|
Onkornix
requested review from
HeadHunter4621,
Anomalous68,
Onkornix and
toasterwaffle12358
fruzzmuffin
reviewed
Nov 2, 2023
Comment on lines
+16
to
+30
| override fun periodic() { | ||
| super.periodic() | ||
| val presentSpeed = motor.get() | ||
|
|
||
| val presentSpeedIsCloseToDesiredSpeedLow : Boolean = ( (desiredSpeed - 0.01) <= presentSpeed ) | ||
| val presentSpeedIsCloseToDesiredSpeedHigh : Boolean = ( (desiredSpeed + 0.01) >= presentSpeed ) | ||
| val presentSpeedIsCloseToDesiredSpeed : Boolean = presentSpeedIsCloseToDesiredSpeedHigh && presentSpeedIsCloseToDesiredSpeedLow | ||
|
|
||
| if ( false == presentSpeedIsCloseToDesiredSpeed ) { | ||
| motor.set(presentSpeed + speedIncrementPerCycle) | ||
| } else { | ||
| speedIncrementPerCycle = 0.0 | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
This code should be in the command
There was a problem hiding this comment.
And it doesn't have to speed up you can just set the speed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the concept of unit testing robot sub-modules, Utilizing the debugger, and reviewing PRs.
Unit tests are a handy tool to help write better code faster and with greater confidence. Unit tests provide the following benefits:
Using the debugger: I'll give a demo of this tomorrow, but the debugger allows you to step through your code as it executes, one line at a time. You can even look at the values of variables!
Reviewing PRs: If you're reading this then you're already well on your way, now try finding something you don't like or have a question about in the source files I changed. Leave a comment, ask a question or request some changes!