a suggestion to run certain tests before new releases #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, log also ok links for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey strider team,
since i played yesterday for the first time with strider i run in the issue with an non existing plugin.
i made a pull request but stuff like that can happen again.
so what i done here is that i check for each module if the repository is online.
if you set the variable
versionCheckin line 15 to true i check if its a github url and try to get the version number provided viapackage.jsonfile. in case there are some version changes i log a warning.so in general this i just to show you my thinking to run certain test before checkout.
in case there are some new versions we could deploy them with the latest version or ask the user if he want to get them automatically installed or something like that.
because when i had my first contact with the software (was via shell) i had for each plugin some commands over and over again. ok i guess u know what i mean :)
so i extract username and repo as well in case for some further handling ...
cheers maik