Also accept char* pointer for fonts #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(thought I had commented before) This looks sane to me and I'd merge it, but IMO it's for @squix78 to decide what the best course of action is at this point. |
Instead of duplication functionality. Because setFont might do more. In fact: it does for in my print fixes: it resets the logBuffer for new number of lines/chars.
|
Any word? I think this should go in. As it is now you're pointing people to a site to make font files, and then they come back with files that don't work. It's so trivial to make both work. Note that I changed it to point to the uint8_t version of setFont instead of just doing the work itself: that way #399 can just reset the logBuffer in one place. |
thijstriemstra
approved these changes
Mar 18, 2024
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The squix.ch tool mentioned in the README maybe provided a
uint8_tarray at one point, or maybe we switched, but as it is now it provides a char array, so the font files from there don't work. This patch fixes that by converting the pointer we get.