Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor clarification added #398

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Minor clarification added #398

merged 1 commit into from
Mar 12, 2024

Conversation

ropg
Copy link
Contributor

@ropg ropg commented Mar 12, 2024

Not wrapping at end of line is really the only difference between what we do and what people might expect, so good to explain it.

@marcelstoer
Copy link
Member

Two ways to fix this

  • document the deviation from the (perceived) expected behavior
  • POLA, we just implement the expected behavior 😜

@ropg
Copy link
Contributor Author

ropg commented Mar 12, 2024

Oh wow, my git-messing shows up as 7 commits for a lousy extra line in the README. I'm sorry, will fix that.

Also: I actually considered implementing proportional wrappping, but the small size of these displays and the fact that it would be computationally significant on older Arduinos kept me from doing it.

Explain where we deviate from what user might expect.
@ropg
Copy link
Contributor Author

ropg commented Mar 12, 2024

Right, now as only one small commit instead of 7...

@marcelstoer marcelstoer merged commit 344fb49 into ThingPulse:master Mar 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants