Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made NQL isomorphic and reduced frontend bundle size #72

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

binary-koan
Copy link

@binary-koan binary-koan commented Dec 6, 2023

refs PROD-21

This is somewhere between a band-aid and the perfect solution. This does

  • Remove server-side-only dependencies so we don't need to polyfill
  • Update how dependencies are used to minimise the frontend bundle size

But in future we should also consider

  • Migrating away from Jison since it's unmaintained and doesn't support ESM/TypeScript
  • Migrating everything to TypeScript
  • Removing querySQL and using mongoKnex directly in places where it's currently used - would remove the need for separate frontend and server entry points

@binary-koan binary-koan added the enhancement New feature or request label Dec 6, 2023
@binary-koan binary-koan self-assigned this Dec 6, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (6f0e065) 79.71% compared to head (928f05f) 80.01%.

Files Patch % Lines
packages/nql-lang/clean-parser.js 0.00% 9 Missing ⚠️
packages/nql-lang/lib/scope.js 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   79.71%   80.01%   +0.29%     
==========================================
  Files           9       12       +3     
  Lines        1568     1611      +43     
  Branches      316      320       +4     
==========================================
+ Hits         1250     1289      +39     
- Misses        313      317       +4     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ronaldlangeveld ronaldlangeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Would be great if @daniellockyer have a peek as well, just to be in the loop with the changes. :) But otherwise, I think it's great! Cheers.

@binary-koan binary-koan removed their assignment Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants