-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made NQL isomorphic and reduced frontend bundle size #72
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
+ Coverage 79.71% 80.01% +0.29%
==========================================
Files 9 12 +3
Lines 1568 1611 +43
Branches 316 320 +4
==========================================
+ Hits 1250 1289 +39
- Misses 313 317 +4
Partials 5 5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Would be great if @daniellockyer have a peek as well, just to be in the loop with the changes. :) But otherwise, I think it's great! Cheers.
refs PROD-21
This is somewhere between a band-aid and the perfect solution. This does
But in future we should also consider
querySQL
and usingmongoKnex
directly in places where it's currently used - would remove the need for separate frontend and server entry points