Update error for missing koenig styles #458
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naz
reviewed
Nov 22, 2022
lib/checks/050-koenig-css-classes.js
Outdated
| @@ -63,7 +63,7 @@ const checkKoenigCssClasses = function checkKoenigCssClasses(theme, options) { | |||
| theme.results.fail[ruleCode] = {}; | |||
| theme.results.fail[ruleCode].failures = [ | |||
| { | |||
| ref: 'styles' | |||
| ref: 'Missing styles or stylesheets' | |||
There was a problem hiding this comment.
This message appears under "Affected files" section, so would read like:
Affected files:
- Missing styles or stylesheets
I think "Missing stylesheets with required class styles" would be a more suitable reference here.
There was a problem hiding this comment.
Agreed! Updated reference text
|
@royalfig did you check how these changes appear in Ghost Admin? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When recently helping a customer update to v5, Jon got hit with this error message, which he found confusing for him and the customer. In particular, the bit about
affected files: styles. The difficulty here is that the error message is not about a specific file — but about missing files.This commit updates the error message to be more explicit:
Missing styles or stylesheets