SPS: Enforce a minimum distance from plug to ring

[TheLastRar]

Aims to reduce the undesired roll when the ring is too close to base of the penetrator.

One of the goals I had was to ensure that hypothetical hilted rings would behave correctly, while having a minimum distance smaller than the hilted distance.

With that in mind, I wanted to avoid a potential issue of a ring swinging under the minimum distance, and popping though.

DPS appears to consider a plane aligned to the base of the penetrator
I decided to take inspiration from this, and consider a plane with the same orientation as the orifice to impose a minimum distance against.

This approach is quite affective at reducing roll where the orifice is nearly aligned with the plug, but loses effectiveness as the orientation of the orifice approaches 90d.

The changes made in this contribution are free and unencumbered software
released into the public domain.

Anyone is free to copy, modify, publish, use, compile, sell, or
distribute this software, either in source code form or as a compiled
binary, for any purpose, commercial or non-commercial, and by any
means.

In jurisdictions that recognize copyright laws, the author or authors
of this software dedicate any and all copyright interest in the
software to the public domain. We make this dedication for the benefit
of the public at large and to the detriment of our heirs and
successors. We intend this dedication to be an overt act of
relinquishment in perpetuity of all present and future rights to this
software under copyright law.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR
OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
OTHER DEALINGS IN THE SOFTWARE.

For more information, please refer to <https://unlicense.org>```

[SenkyDragon]

ambiguous order of operations. Add parens and use || rather than | (although ultimately it probably results in the same machine code)

[SenkyDragon]

Why is this beneficial vs just using orfDistance directly?

[TheLastRar]

This was done for hypothetical hilted/uni-directional rings.

If we use orfDistance directly, we could end-up lerping out the min distance logic if the socket goes behind the plug, causing the plug to suddenly pull back.

[TheLastRar]

Including an sketch of the two

Where the dashed line shows the path of the plug as it moves pass/though the socket
I wanted to avoid the plug starting to lerp towards the original socket as it reaches the far end of the circled area.

[SenkyDragon]

this arbitrarily just moves the socket backward, in respect to the direction it is facing, which I also don't think is correct in this scenario

[TheLastRar]

The idea was based on your suggestion to "pretend" the rings are a bit forward.

Where you thinking of a different method when you suggested that?

[TheLastRar]

A Sketch showing what I'm attempting to achieve

[SenkyDragon]

What's the ultimate goal? DPS's proximity solver is... not great, so I'm reluctant to take much inspiration from it at all. Much of DPS's logic feels very much like a "throw things at the wall and see what works", while I think we can do better by defining how the behavior should actually work.

[TheLastRar]

Are you referring to this section of code? or the whole PR in general?

[TheLastRar]

The ultimate goal was to avoid the sudden rotations in the plug under lateral movements as it gets close to the socket

Ideally I think this should be handled directly in the solver algorithm, however, I was unable to do so.

[TheLastRar]

Returning to elaborate on my responses

I haven't really battle tested this as much as I wanted to, I ended up switching back to DPS full time I think due to hilted range being reduced