Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add friends checkbox to separate local state, for IsOnFriendsList param #231

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jashepp
Copy link

@Jashepp Jashepp commented Jan 29, 2024

This adds a friends checkbox to separate local state, to allow the new IsOnFriendsList VRChat parameter to be used.

image

Related issue: #182

I did think of other ways of doing this, like having a new option instead of combining it with local state, or also renaming the 'In local' and 'In remote' text when it's checked, but a lot more would have to be changed to do either. This PR can turn into that, or it can be done later with this small implementation for now instead?

I have tested this manually and when checked/on, it works as expected. I also looked at the built animation controller and it looks good in there too. Tested for myself, for friends, and when unfriending they see it change to the remote state automatically, same when befriending someone, they see it change to the 'local' state.

The changes made in this contribution are free and unencumbered software
released into the public domain.

Anyone is free to copy, modify, publish, use, compile, sell, or
distribute this software, either in source code form or as a compiled
binary, for any purpose, commercial or non-commercial, and by any
means.

In jurisdictions that recognize copyright laws, the author or authors
of this software dedicate any and all copyright interest in the
software to the public domain. We make this dedication for the benefit
of the public at large and to the detriment of our heirs and
successors. We intend this dedication to be an overt act of
relinquishment in perpetuity of all present and future rights to this
software under copyright law.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR
OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
OTHER DEALINGS IN THE SOFTWARE.

For more information, please refer to <https://unlicense.org>

@Jashepp Jashepp force-pushed the feat-toggle-IsOnFriendsList branch from 59f2d32 to dd6ac0d Compare March 24, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant