Move Insert #248
Open
Move Insert #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AraHaan
suggested changes
Mar 30, 2024
| } | ||
| } | ||
|
|
||
| public bool Move(string from, string to, int index) { |
| @@ -64,7 +64,31 @@ public class MenuManager { | |||
| return true; | |||
| } | |||
|
|
|||
| public bool Move(string from, string to) { | |||
| public void Insert(VRCExpressionsMenu menu, VRCExpressionsMenu.Control item, int index) { | |||
Comment on lines
+19
to
+25
|
|
||
| var adv = new Foldout { | ||
| text = "Advanced Options", | ||
| value = false | ||
| }; | ||
| content.Add(adv); | ||
|
|
There was a problem hiding this comment.
I feel like it does not need to be listed under "Advanced Options" as it could be seen to be trivial to allow it and not really too Advanced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to set an arbitrary index for Move Menu Item rather than always moving it to the end