add RemoveBlendshapeVertices feature #260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SenkyDragon
reviewed
Mar 22, 2024
com.vrcfury.vrcfury/Editor/VF/Feature/RemoveBlendshapeVerticesBuilder.cs
Outdated
Show resolved
Hide resolved
SenkyDragon
reviewed
Mar 22, 2024
com.vrcfury.vrcfury/Editor/VF/Feature/RemoveBlendshapeVerticesBuilder.cs
Outdated
Show resolved
Hide resolved
SenkyDragon
reviewed
Mar 22, 2024
com.vrcfury.vrcfury/Editor/VF/Feature/RemoveBlendshapeVerticesBuilder.cs
Outdated
Show resolved
Hide resolved
SenkyDragon
reviewed
Mar 22, 2024
com.vrcfury.vrcfury/Editor/VF/Feature/RemoveBlendshapeVerticesBuilder.cs
Outdated
Show resolved
Hide resolved
SenkyDragon
reviewed
Mar 22, 2024
com.vrcfury.vrcfury/Editor/VF/Feature/RemoveBlendshapeVerticesBuilder.cs
Outdated
Show resolved
Hide resolved
SenkyDragon
reviewed
Mar 22, 2024
com.vrcfury.vrcfury/Editor/VF/Feature/RemoveBlendshapeVerticesBuilder.cs
Outdated
Show resolved
Hide resolved
|
Alright, I'll take the review as interest :) I'll refactor it and re-request a review once it's cleaner! |
deletes all vertices affected by a given blendshape from your mesh at build time
PiMaker
force-pushed
the
delete-blendshape-vertices
branch
from
336f252
to
6fecfc8
Compare
|
@SenkyDragon Is there still interest in merging this feature? Anything I should change/refactor? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletes all vertices affected by a given blendshape from your mesh at build time. Idea sort of comes from https://github.com/euan142/LazyOptimiser, which is MIT, so I also originally based my code on euan's. Heavily modified to fit the framework of Fury instead of Lazy.
I made this for my personal avatar project, where certain outfits don't need to have the full skin underneath. With this I can remove it non-destructively by simply (ab)using the existing "scale away" blendshapes.
Factors out a
BlendshapeSelectormethod inVRCFuryActionEditor.csto re-use in this class. Let me know if the code is okay, happy to refactor a bit or clean stuff up.