refactor: wiki_select.jsx to functional component #5784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmitJoki
reviewed
Apr 23, 2024
| }; | ||
|
|
||
| const url = (wiki) => { | ||
| const subdomain = wiki.language || 'www'; |
There was a problem hiding this comment.
This language || 'www' is duplicated here and is used in other places of the codebase. Maybe a good idea to refactor this into a function and use it everywhere
function getWikiSubdomain(wiki) {
return wiki.language || 'www';
}
AmitJoki
reviewed
Apr 23, 2024
Comment on lines
+89
to
+108
| const filterOptionsLong = function (val) { | ||
| return availableOptions.filter(wiki => | ||
| wiki.label.toLowerCase().includes(val.toLowerCase()) | ||
| ).slice(0, 10); // limit the options for better performance | ||
| }; | ||
|
|
||
| // If the input is at least three characters, it will be matched anywhere in the string | ||
|
|
||
| const filterOptionsShort = function (val) { | ||
| return availableOptions.filter(wiki => | ||
| wiki.label.toLowerCase().includes(val.toLowerCase()) | ||
| ).slice(0, 10); | ||
| }; | ||
|
|
||
| const loadOptions = function (inputValue, callback) { | ||
| if (inputValue.length < 3) { | ||
| callback(filterOptionsShort(inputValue)); | ||
| } | ||
| callback(filterOptionsLong(inputValue)); | ||
| }; |
There was a problem hiding this comment.
It seems like filterOptionsLong and filterOptionsShort are doing the same thing. Futher more in loadOptions, we are checking for less than 3 but we are not returning within it and calling the callback again outside which does not look right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Part of #5393 (Component refactor for React class components)
Refactors Class component to a function component for
wiki_select.jsxScreenshots