Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Node v20 prebuilds #1000

Merged
merged 2 commits into from
May 1, 2023
Merged

Add support for Node v20 prebuilds #1000

merged 2 commits into from
May 1, 2023

Conversation

Chicken
Copy link
Contributor

@Chicken Chicken commented May 1, 2023

Future Node LTS release, at the moment current release.

@Chicken Chicken requested review from JoshuaWise and a team as code owners May 1, 2023 19:34
mceachen
mceachen previously approved these changes May 1, 2023
Copy link
Member

@mceachen mceachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Copy link
Member

@mceachen mceachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mceachen mceachen merged commit ec51397 into WiseLibs:master May 1, 2023
20 checks passed
mateuszradomski added a commit to l2beat/byor that referenced this pull request Jun 21, 2023
WiseLibs/better-sqlite3#1000 adds support for
prebuilt binaries while using node v20.  This reduces our yarn source
time from 45 seconds to 7 seconds and removes the need to install
python3, make, gcc and g++. Also our CI is going to be faster :)
mateuszradomski added a commit to l2beat/byor that referenced this pull request Jun 21, 2023
* Initial draft of the new README

* Update better-sqlite3 to 8.4.0 to get prebuilt binaries

WiseLibs/better-sqlite3#1000 adds support for
prebuilt binaries while using node v20.  This reduces our yarn source
time from 45 seconds to 7 seconds and removes the need to install
python3, make, gcc and g++. Also our CI is going to be faster :)

* Add sqlite3

* Use code blocks for the readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants