Remove node.js v14 builds and tests (runtime EOL) #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4heshd
changed the title
mceachen
approved these changes
May 1, 2023
|
@mceachen I think we should. We should also mention the possibly breaking change in BIG BAD BALD letters in the release note. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node v14 just reached EOL. This would be a proactive measure to avoid getting bombarded with build errors in future builds. This would also make tests and builds finish quicker. Not vital to test against a runtime that isn't actively supported anymore.
I've also removed the quite unnecessary non-LTS tests for Node v19 (which also will soon reach EOL).